Bug 1308557
| Summary: | python-grapefruit: Provide a Python 3 subpackage | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Petr Viktorin (pviktori) <pviktori> | ||||
| Component: | python-grapefruit | Assignee: | Praveen Kumar <kumarpraveen.nitdgp> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 24 | CC: | ariel.barria, cstratak, dkrejci, ishcherb, kumarpraveen.nitdgp | ||||
| Target Milestone: | --- | Keywords: | Reopened | ||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | python-grapefruit-0.1a4-5.fc27 python-grapefruit-0.1a4-5.fc26 python-grapefruit-0.1a4-3.fc25 python-grapefruit-0.1a4-3.fc24 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2017-03-03 21:50:47 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1285816, 1312032, 1356653 | ||||||
| Attachments: |
|
||||||
|
Description
Petr Viktorin (pviktori)
2016-02-15 13:51:32 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle. Changing version to '24'. More information and reason for this action is here: https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase Hello everyone. Adding support for python3. SPEC: https://arielb.fedorapeople.org/python-grapefruit.spec SRPM: https://arielb.fedorapeople.org/python-grapefruit-0.1a4-1.fc24.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=15105162 Hi Ariel,
I have some comments:
* Please, add the %check section, tests are present, you can run them with `%{__pythonX} setup.py test`.
* There is a typo in URL, please delete `%` at the end.
And rpmlint output:
* `python-grapefruit.spec:14: W: mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 7)`
* `python-grapefruit.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/grapefruit.py 644 /usr/bin/python`
* `python3-grapefruit.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/grapefruit.py 644 /usr/bin/python`
python-grapefruit-0.1a4-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-7cacb84cd7 python-grapefruit-0.1a4-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-ef645f5614 python-grapefruit-0.1a4-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. python-grapefruit-0.1a4-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. Created attachment 1258810 [details] Patch to fix python3-grapefruit dragging in Python 2 Reopening the issue, as python3-grapefruit-0.1a4-4 RPM requires both Python 2 and Python 3. There is a stray "/usr/bin/python" shebang in one of the files, which auto-generates the dependency on Python 2. You may find the change needed to fix auto-generating Python 2 dependency attached. Please review and apply it. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=18126431 python-grapefruit-0.1a4-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-371de561fc python-grapefruit-0.1a4-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ce95a69a4b python-grapefruit-0.1a4-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-371de561fc python-grapefruit-0.1a4-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-ce95a69a4b python-grapefruit-0.1a4-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. python-grapefruit-0.1a4-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. |