Bug 1308734

Created attachment 1127456 [details]
Customers console.vv

I've submitted a similar fix for the very same issue on Boxes.
Here is the commit: https://git.gnome.org/browse/gnome-boxes/commit/?id=8f8f5882a2ddc50ffc6e784fcf6ef49cb4f6fa83

At that point we ended up agreeing that the solution must be provided by the client. Now, I start thinking that the solution can be provided by spice-gtk.

Do they use the File -> Usb Devices menu to share devices ?
From the description (virt-viewer version) I understand their client
machine is running RHEL-7.
I assume their VM is configured to use "Native" USB Support, right ?

Currently, the usb filter does not apply to manual redirection of USB devices,
only for auto-share. If a user manually picks up a USB device from the menu
File->USB Device Selection then Spice (remote-viewer/spice-gtk) tries to
usbredir that device to the guest.

To workaround mistakenly choosing the keyboard, one can use the mouse to
un-redirect the device (using the same menu File->Usb Device Selection).

This may just be a documentation bug as stated below by the end customer:

Unfortunately, this answer and explanation will not be acceptable. 

1. Once you've accidentally re-directed your KVM switch (keyboard/mouse) input devices, they are "disconnected" from the physical client system. Therefore, one cannot "reverse" the process to remove the re-direction. This process works fine for scanners/printers/USB drives, but not KVM.

2. Documentation:

The USB Filter Editor is a Windows tool used to configure the usbfilter.txt policy file. The policy rules defined in this file allow or deny the pass-through of specific USB devices from client machines to virtual machines managed using the Red Hat Enterprise Virtualization Manager. The policy file resides on the Red Hat Enterprise Virtualization Manager in the following location:

/etc/ovirt-engine/usbfilter.txt
Changes to USB filter policies do not take effect unless the ovirt-engine service on the Red Hat Enterprise Virtualization Manager server is restarted. 

*** Documentation and architecture state that you can filter out devices. 

This is still a bug or should be an RFE. If it isn't fixed, all documentation needs to be updated to state USBFilter is only for automatically re-directed devices and doesn't exact work as described.

(In reply to Frank DeLorey from comment #6)
> This may just be a documentation bug as stated below by the end customer:
> 
> Unfortunately, this answer and explanation will not be acceptable. 
> 
> 1. Once you've accidentally re-directed your KVM switch (keyboard/mouse)
> input devices, they are "disconnected" from the physical client system.
> Therefore, one cannot "reverse" the process to remove the re-direction. This
> process works fine for scanners/printers/USB drives, but not KVM.
> 
> 2. Documentation:
> 
> The USB Filter Editor is a Windows tool used to configure the usbfilter.txt
> policy file. The policy rules defined in this file allow or deny the
> pass-through of specific USB devices from client machines to virtual
> machines managed using the Red Hat Enterprise Virtualization Manager. The
> policy file resides on the Red Hat Enterprise Virtualization Manager in the
> following location:
> 
> /etc/ovirt-engine/usbfilter.txt
> Changes to USB filter policies do not take effect unless the ovirt-engine
> service on the Red Hat Enterprise Virtualization Manager server is
> restarted. 
> 
> *** Documentation and architecture state that you can filter out devices. 
> 
> This is still a bug or should be an RFE. If it isn't fixed, all
> documentation needs to be updated to state USBFilter is only for
> automatically re-directed devices and doesn't exact work as described.

the doc was fixed, it states clear that the filter policy is used for automatic re-direction: "...allow or deny automatic pass-through ...".

I tested this and the bug is still there.
Maybe this can be divided into two bugs:

1) usb-filter does not work - if I use admin vv-file: enable-usb-autoshare=1 and
usb-filter=-1,-1,-1,-1,0 all devices are auto-shared (automatically redirected to guest when physically connected to client) to guest.

2) HID devices are automatically redirected as well - with exception that they are not usable in guest (cannot type anything in guest nor in client if keyboard was redirected) and relevant checkbox in USB redirection menu is not checked. So it is some quasi-redirection.


client win7:
Virtual Machine Viewer 2.0-240
UsbDk 1.0.19.0

guest win10
RHEV-Tools 4.2.4

cannot reproduce with rhel7.5 client.

Created attachment 1414787 [details]
spice-debug log: unplug and plug keyboard after connection to win10 VM

This bug has not been marked as blocker for oVirt 4.3.0.
Since we are releasing it tomorrow, January 29th, this bug has been re-targeted to 4.3.1.

I have just tested this with a Windows 7 guest and client and this still happens. I used a mouse to confirm bug is still valid.

usb-filter=-1,-1,-1,-1,0

RHEL-7.6-updates-20190220.0
RHVM - rhv-4.3.1-2/el7/

(In reply to Bill Sanford from comment #13)
> I have just tested this with a Windows 7 guest and client and this still
> happens. I used a mouse to confirm bug is still valid.
> 
> usb-filter=-1,-1,-1,-1,0
> 
> RHEL-7.6-updates-20190220.0
> RHVM - rhv-4.3.1-2/el7/

can you clarify, that the keyboard and the mouse can be redirected manually, but are not re-directed automatically upon connection to the guest. 
Please, use the latest RHV 4.3 windows client, and rhel 7.7 v.35-4 of spice-gtk

I can not reproduce this bug using win7/(win10 tried) client and latest rhel7.7 guest with spice-gtk 35.4
rhv4.3.2.1-0.1.el7

vv-file:
..
usb-filter=-1,-1,-1,-1,0
enable-usb-autoshare=1
..

reproduction steps:
1. Connect to guest using vv-file with options stated above ^^
2. Focus remote-viewer window
3. physically unplug and plug USB mouse and keyboard

Nor mouse neither keyboard are redirected to guest after their physical reconnection to client.