Bug 1308742

Summary: Review Request: collectd5 - Statistics collection daemon for filling RRD files
Product: [Fedora] Fedora Reporter: Marc Fournier <rh>
Component: Package ReviewAssignee: Ruben Kerkhof <ruben>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: mattia.verga, package-review, ppisar, rh, ruben
Target Milestone: ---Flags: ruben: fedora-review+
mattia.verga: needinfo? (rh)
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-08-10 11:31:16 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Marc Fournier 2016-02-15 22:23:12 UTC 
Spec URL: https://github.com/mfournier/collectd-fedora-packaging/blob/el6-collectd5/collectd5.spec

SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/3483/12923483/collectd5-5.5.1-0.el6.src.rpm

Description: collectd is already packaged in Fedora & EPEL (package name: collectd). This review request only aims EPEL6. But first a bit of context:

At the time EPEL6 got bootstrapped, collectd 4.x was current, so this is what ended up in EPEL6. Since then, collectd released its next major version, which is part of Fedora since F18, and also EPEL7. As the upgrade path from collectd 4 to collectd 5 is non-trivial, it was decided EPEL6 would stick to the latest 4.x release.

But now more and more EL6 users complain how out of date what "yum install collectd" offers them. So after discussing this with Ruben Kerkhof (maintainer for Fedora packages), I'd like to suggest having both version in EL6: the last 4.x release named collectd, and the current 5.x release named collectd5 (this is the same solution FreeBSD chose for the same issue).

The Specfile I referenced above is forked off the current master branch of http://pkgs.fedoraproject.org/cgit/collectd.git and was then modified to build as collectd5-*.rpm with the specific requirements of the EL6 platform, and was setup to conflict with the collectd-*.rpm package. No way of installing both versions in parallel, all the file paths conflict. No 4 to 5 upgrade path neither.

This is my first package, so I'd need a sponsor. I'm part of the upstream maintainers though.
The koji build is here: http://koji.fedoraproject.org/koji/taskinfo?taskID=12923478
and I also provided a copr repo here: https://copr.fedorainfracloud.org/coprs/mfo/collectd5-EL6/

Fedora Account System Username: mfo

Thanks for your attention & future reviews :-)
Comment 1 Ruben Kerkhof 2016-02-27 17:48:33 UTC 
I'll do the review shortly. I'd also like to sponsor Marc. We've worked together on the upstream Collectd project for a while now and I can attest to the quality of his work.
Comment 2 Ruben Kerkhof 2016-07-18 20:06:55 UTC 
I've carefully reviewed this, but didn't find any issues since this is an almost identical package as the current package in Fedora.

This package is approved.

Marc, please continue from step 8 in the process at https://fedoraproject.org/wiki/Package_Review_Process. Let me know if you need any help.
Comment 3 Mattia Verga 2021-07-24 09:16:09 UTC 
So, what's the status of this old Review request? Should we close it or it's still valid?