Bug 1308807

Summary:	tests : Modifying tests for crypt xlator
Product:	[Community] GlusterFS	Reporter:	Jiffin <jthottan>
Component:	tests	Assignee:	Jiffin <jthottan>
Status:	CLOSED NOTABUG	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	3.5.8	CC:	bugs, jthottan, ndevos
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1308806	Environment:
Last Closed:	2016-02-16 07:18:07 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1298520, 1303033, 1308806
Bug Blocks:

Description Jiffin 2016-02-16 07:15:17 UTC

+++ This bug was initially created as a clone of Bug #1308806 +++

+++ This bug was initially created as a clone of Bug #1303033 +++

+++ This bug was initially created as a clone of Bug #1298520 +++

Description of problem:
The test cases for crypt xlator is creating core for client processes due to absence of master key file.Before enabling it is required to create the same

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
log file for gluster nfs 
 [2016-01-14 08:13:15.740835] E [crypt.c:4298:master_set_master_vol_key]
    0-test1-crypt: FATAL: missing master key
    [2016-01-14 08:13:15.740859] E [MSGID: 101019]
    [xlator.c:429lator_init] 0-test1-crypt: Initialization of volume
    'test1-crypt' failed, review your volfile again
    [2016-01-14 08:13:15.740890] E [MSGID: 101066]
    [graph.c:324:glusterfs_graph_init] 0-test1-crypt: initializing
    translator failed
    [2016-01-14 08:13:15.740904] E [MSGID: 101176]
    [graph.c:670:glusterfs_graph_activate] 0-graph: init failed
    [2016-01-14 08:13:15.741676] W [glusterfsd.c:1231:cleanup_and_exit]
    (-->/usr/sbin/glusterfs(mgmt_getspec_cbk+0x307) [0x40d287]
    -->/usr/sbin/glusterfs(glusterfs_process_volfp+0x117) [0x4086c7]
    -->/usr/sbin/glusterfs(cleanup_and_exit+0x4d) [0x407e1d] ) 0-: received
    signum (0), shutting down

--- Additional comment from Vijay Bellur on 2016-01-14 05:28:25 EST ---

REVIEW: http://review.gluster.org/13240 (tests : Modifying crypt xlators unit tests) posted (#1) for review on master by jiffin tony Thottan (jthottan)

--- Additional comment from Vijay Bellur on 2016-01-19 03:40:35 EST ---

REVIEW: http://review.gluster.org/13240 (tests: set master key before enabling crypt xlator) posted (#2) for review on master by jiffin tony Thottan (jthottan)

--- Additional comment from Vijay Bellur on 2016-01-19 08:00:46 EST ---

REVIEW: http://review.gluster.org/13240 (tests : Modifying crypt xlators unit tests) posted (#3) for review on master by jiffin tony Thottan (jthottan)

--- Additional comment from Vijay Bellur on 2016-01-24 07:35:04 EST ---

COMMIT: http://review.gluster.org/13240 committed in master by Niels de Vos (ndevos) 
------
commit ca4d4a26a553bac9c627bc6e6d6c9fa1f9435297
Author: Jiffin Tony Thottan <jthottan>
Date:   Thu Jan 14 15:07:47 2016 +0530

    tests : Modifying crypt xlators unit tests
    
    The "encryption.master-key" should be set before enabling crypt xlators.
    Otherwise glusterfs client process(like gluster-NFS) will crash due to the
    failure in intialising crypt xlator.
    
    You can see the following messages in client log file
    [2016-01-14 08:13:15.740835] E [crypt.c:4298:master_set_master_vol_key]
    0-test1-crypt: FATAL: missing master key
    [2016-01-14 08:13:15.740859] E [MSGID: 101019]
    [xlator.c:429lator_init] 0-test1-crypt: Initialization of volume
    'test1-crypt' failed, review your volfile again
    [2016-01-14 08:13:15.740890] E [MSGID: 101066]
    [graph.c:324:glusterfs_graph_init] 0-test1-crypt: initializing
    translator failed
    [2016-01-14 08:13:15.740904] E [MSGID: 101176]
    [graph.c:670:glusterfs_graph_activate] 0-graph: init failed
    [2016-01-14 08:13:15.741676] W [glusterfsd.c:1231:cleanup_and_exit]
    (-->/usr/sbin/glusterfs(mgmt_getspec_cbk+0x307) [0x40d287]
    -->/usr/sbin/glusterfs(glusterfs_process_volfp+0x117) [0x4086c7]
    -->/usr/sbin/glusterfs(cleanup_and_exit+0x4d) [0x407e1d] ) 0-: received
    signum (0), shutting down
    
    Change-Id: I124deda505d128eacb15ca20fbdcd1593cb8eba3
    BUG: 1298520
    Signed-off-by: Jiffin Tony Thottan <jthottan>
    Reviewed-on: http://review.gluster.org/13240
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>
    CentOS-regression: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>

--- Additional comment from Niels de Vos on 2016-01-24 07:36:33 EST ---

Please check if it is needed to backport this to 3.7 and 3.6 too. File bugs for the affected versions and send backports please.

--- Additional comment from Jiffin on 2016-01-29 05:04:35 EST ---

Sorry for the delay, I will check whether backport is needed and do the same

--- Additional comment from Vijay Bellur on 2016-01-29 06:37:22 EST ---

REVIEW: http://review.gluster.org/13320 (tests : Modifying crypt xlators unit tests) posted (#2) for review on release-3.7 by jiffin tony Thottan (jthottan)

--- Additional comment from Vijay Bellur on 2016-02-09 09:12:53 EST ---

COMMIT: http://review.gluster.org/13320 committed in release-3.7 by Jeff Darcy (jdarcy) 
------
commit 75b7fd344de28f9c79940722f9d9f9e5342ddcd8
Author: Jiffin Tony Thottan <jthottan>
Date:   Thu Jan 14 15:07:47 2016 +0530

    tests : Modifying crypt xlators unit tests
    
    Backport of http://review.gluster.org/#/c/13240/
    
    The "encryption.master-key" should be set before enabling crypt xlators.
    Otherwise glusterfs client process(like gluster-NFS) will crash due to the
    failure in intialising crypt xlator.
    
    You can see the following messages in client log file
    [2016-01-14 08:13:15.740835] E [crypt.c:4298:master_set_master_vol_key]
    0-test1-crypt: FATAL: missing master key
    [2016-01-14 08:13:15.740859] E [MSGID: 101019]
    [xlator.c:429lator_init] 0-test1-crypt: Initialization of volume
    'test1-crypt' failed, review your volfile again
    [2016-01-14 08:13:15.740890] E [MSGID: 101066]
    [graph.c:324:glusterfs_graph_init] 0-test1-crypt: initializing
    translator failed
    [2016-01-14 08:13:15.740904] E [MSGID: 101176]
    [graph.c:670:glusterfs_graph_activate] 0-graph: init failed
    [2016-01-14 08:13:15.741676] W [glusterfsd.c:1231:cleanup_and_exit]
    (-->/usr/sbin/glusterfs(mgmt_getspec_cbk+0x307) [0x40d287]
    -->/usr/sbin/glusterfs(glusterfs_process_volfp+0x117) [0x4086c7]
    -->/usr/sbin/glusterfs(cleanup_and_exit+0x4d) [0x407e1d] ) 0-: received
    signum (0), shutting down
    
    Upstream reference
    -------------------
    >Change-Id: I124deda505d128eacb15ca20fbdcd1593cb8eba3
    >BUG: 1298520
    >Signed-off-by: Jiffin Tony Thottan <jthottan>
    >Reviewed-on: http://review.gluster.org/13240
    >Smoke: Gluster Build System <jenkins.com>
    >Reviewed-by: Niels de Vos <ndevos>
    >CentOS-regression: Gluster Build System <jenkins.com>
    >NetBSD-regression: NetBSD Build System <jenkins.org>
    >(cherry picked from commit ca4d4a26a553bac9c627bc6e6d6c9fa1f9435297)
    
    Change-Id: I8073765b02cd4bebc202fbae5ef7558df25ea664
    BUG: 1303033
    Reviewed-on: http://review.gluster.org/13320
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: Jeff Darcy <jdarcy>
    CentOS-regression: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>

--- Additional comment from Vijay Bellur on 2016-02-16 02:08:29 EST ---

REVIEW: http://review.gluster.org/13453 (tests : Modifying crypt xlators unit tests) posted (#1) for review on release-3.6 by jiffin tony Thottan (jthottan)