Bug 1309244
Summary: | python-sendgrid: Provide a Python 3 subpackage | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Petr Viktorin (pviktori) <pviktori> |
Component: | python-sendgrid | Assignee: | Daniel Bruno <dbruno> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 24 | CC: | cstratak, dbruno, dkrejci, ishcherb |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | python-sendgrid-3.6.5-1.fc26 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2017-04-05 22:00:15 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1358248 | ||
Bug Blocks: | 1285816, 1312032 | ||
Attachments: |
Description
Petr Viktorin (pviktori)
2016-02-17 10:25:15 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle. Changing version to '24'. More information and reason for this action is here: https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase Hello Daniel, Do you need any help adding Python 3 support to the RPM? If you need more instructions, a [guide] for porting Python-based RPMs is available. [guide] http://python-rpm-porting.readthedocs.org/en/latest/index.html Created attachment 1181046 [details] add Python 3 & update version Hi, I have made a patch to add Python3 support and update the version. There is a new Require in the latest version, which is not packaged yet. It is: python-http_client (https://github.com/sendgrid/python-http-client). python-sendgrid will not work as long as http_client is unpackaged. Created attachment 1191564 [details] add Python 3 & version update Hi Daniel, python-http-client is ready and there is a new patch for sendgrid. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=15284575 Created attachment 1265158 [details] Patch to update to current version and provide Python 3 subpackage Hi, I have updated Dominika's patch to the latest upstream version (3.6.3) and included running tests. You may find the new patch attached. Please review it and do the update. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=18507331 The package places the tests at {python2_sitelib}/test and {python3_sitelib}/test and not in its own subdirectory which can be problematic and create conflicts with other packages. See bug 1418794 Ideally upstream should be notified for that and place the tests under the sendgrid directory (maybe also the examples folder? The examples are not packaged though). Created a PR upstream to notify them about the issue (https://github.com/sendgrid/sendgrid-python/pull/300). Regarding examples, I believe we do not need them to be under sendgrid directory to create examples package, so I will add it as soon as the issue with tests is solved. Created attachment 1267038 [details] Patch to update to current version and provide Python 3 subpackage I have created a patch with a temporary solution (explicitly excluding tests from {python2_sitelib}) until the above PR is reviewed/merged/released. Also added examples package. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=18647964 Created attachment 1267780 [details] Patch to update to current version and provide Python 3 subpackage Please find a patch attached with an update to the latest version with tests issue resolved. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=18694981 python-sendgrid-3.6.5-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-8957be79c5 python-sendgrid-3.6.5-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-8957be79c5 python-sendgrid-3.6.5-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days |