Bug 1309364

Summary: Use-after-free in case resolving hosts or networks fail
Product: Red Hat Enterprise Linux 6 Reporter: Jakub Hrozek <jhrozek>
Component: nss-pam-ldapdAssignee: Jakub Hrozek <jhrozek>
Status: CLOSED ERRATA QA Contact: Stefan Kremen <skremen>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 6.8CC: arthur, jhrozek, pkis, skremen
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: nss-pam-ldapd-0.7.5-32.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-05-10 19:46:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jakub Hrozek 2016-02-17 15:47:56 UTC
Description of problem:
This issue was found by Coverity:
1. Defect type: USE_AFTER_FREE ΒΆ
41. nss-pam-ldapd-0.7.5/nss/networks.c:122: pass_closed_arg: Passing closed handle "fp->fd" as an argument to "tio_skipall".
Expand
2. Defect type: USE_AFTER_FREE
38. nss-pam-ldapd-0.7.5/nss/networks.c:105: pass_closed_arg: Passing closed handle "fp->fd" as an argument to "tio_skipall".
Expand
3. Defect type: USE_AFTER_FREE
40. nss-pam-ldapd-0.7.5/nss/hosts.c:208: pass_closed_arg: Passing closed handle "fp->fd" as an argument to "tio_skipall".
Expand
4. Defect type: USE_AFTER_FREE
39. nss-pam-ldapd-0.7.5/nss/hosts.c:176: pass_closed_arg: Passing closed handle "fp->fd" as an argument to "tio_skipall". 

Version-Release number of selected component (if applicable):


How reproducible:
not sure. We should make sure getent hosts and getent networks still works.

Comment 1 Arthur de Jong 2016-02-17 21:40:35 UTC
Not 100% sure if this is the same issue but it is likely this:
  http://lists.arthurdejong.org/nss-pam-ldapd-users/2014/msg00042.html
and fixed by:
  http://arthurdejong.org/git/nss-pam-ldapd/commit/?id=1a59c4e3945dedafc8e63dc2688ddf035f0af656

The commit is on top of 0.7.19 but was never part of a 0.7 release. The fix was released in 0.8.14 and 0.9.3.

Comment 2 Jakub Hrozek 2016-02-18 07:46:56 UTC
(In reply to Arthur de Jong from comment #1)
> Not 100% sure if this is the same issue but it is likely this:

Not completely, this one was caused by my sloppy backporting of a tio.c patch :-)

>   http://lists.arthurdejong.org/nss-pam-ldapd-users/2014/msg00042.html
> and fixed by:
>  
> http://arthurdejong.org/git/nss-pam-ldapd/commit/
> ?id=1a59c4e3945dedafc8e63dc2688ddf035f0af656
> 
> The commit is on top of 0.7.19 but was never part of a 0.7 release. The fix
> was released in 0.8.14 and 0.9.3.

Yes, this is exactly what I was about to commit. Thanks for chiming in!

Comment 6 errata-xmlrpc 2016-05-10 19:46:03 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-0758.html