Bug 1309376
| Summary: | python-py9p: Provide a Python 3 subpackage | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Petr Viktorin (pviktori) <pviktori> | ||||||||
| Component: | python-py9p | Assignee: | Peter V. Saveliev <svinota.saveliev> | ||||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | unspecified | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | 24 | CC: | cstratak, dkrejci, lbalhar, svinota.saveliev | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | python-py9p-1.0.9-8.fc26 | Doc Type: | Bug Fix | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2016-11-18 16:19:12 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | |||||||||||
| Bug Blocks: | 1285816, 1333770 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Petr Viktorin (pviktori)
2016-02-17 16:12:34 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle. Changing version to '24'. More information and reason for this action is here: https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase Hello Peter, Do you need any help adding Python 3 support to the RPM? If you need more instructions, a [guide] for porting Python-based RPMs is available. [guide] http://python-rpm-porting.readthedocs.org/en/latest/index.html Created attachment 1199383 [details] Add Python 3 Hi Peter, here is the change needed to add Python 3 support. Could you please review it and do the update? Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15555797 Hello, Dominiko.
In your patch source URL doesn't work. You probably wanted something like %{url}/archive/%{version}.tar.gz#%{srcname}-%{version}.tar.gz
Otherwise, it looks good to me.
Created attachment 1202773 [details]
Add Python 3
Fixed Source. Thanks Lumír!
Created attachment 1203191 [details]
Added Python 2/3 subpackages and apps switched to Python 3
Hello.
During another review I've found few issues:
- Packages 9pfs and fuse9p have still shebangs with Python 2 (I don't know why) and related dependency on /usr/bin/python2
- You shouldn't use setup.py.in - better is to generate setup.py with `make force-version`
- I think that if we switch 9pfs and fuse9p to Python 3 it should depend on python3-py9p instead python-py9p which is python 2 version.
I am providing new patch, where all these issues are fixed.
Dominiko, could you please do a review?
Thank you and have a nice day.
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15732341 Hi Lumír, your patch looks good to me. If the maintainer has nothing against, we can push this changes after a week. :) Fixed some minor additional issues that I identified and pushed the changed for rawhide. If you would like it for F25 as well, please reopen the bug. |