Bug 1309519
| Summary: | syntax errors in common.sh - check_rpm_to() | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Alois Mahdal <amahdal> |
| Component: | preupgrade-assistant | Assignee: | Petr Stodulka <pstodulk> |
| Status: | CLOSED ERRATA | QA Contact: | Tereza Cerna <tcerna> |
| Severity: | high | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 6.8 | CC: | fkluknav, mflitter, ovasik, phracek, pstodulk, tcerna, ttomecek |
| Target Milestone: | rc | Keywords: | Extras |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | preupgrade-assistant-2.1.4-10.el6 | Doc Type: | Bug Fix |
| Doc Text: |
Do not document.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-05-11 08:26:52 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Reported in upstream, PR added: https://github.com/phracek/preupgrade-assistant/issues/77 My mistake. I uses locally updated file instead of the uploaded one. Thanks for quick catch. setting doc_text- -------------------------------------------
Verified in:
preupgrade-assistant-2.1.5-2.el6.noarch
PASS
-------------------------------------------
# bash -n /usr/share/preupgrade/common.sh
# echo $?
0
# bash -n /usr/share/premigrate/common.sh
# echo $?
0
-------------------------------------------
Reproduced in:
preupgrade-assistant-2.1.4-9.el6.noarch
FAIL
-------------------------------------------
# bash -n /usr/share/preupgrade/common.sh
/usr/share/preupgrade/common.sh: line 226: syntax error near unexpected token `}'
/usr/share/preupgrade/common.sh: line 226: `}'
# echo $?
2
# bash -n /usr/share/premigrate/common.sh
/usr/share/premigrate/common.sh: line 226: syntax error near unexpected token `}'
/usr/share/premigrate/common.sh: line 226: `}'
# echo $?
2
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2016-1022.html |
Description of problem ====================== Syntax errors are in common.sh: /usr/share/preupgrade/common.sh: line 226: syntax error near unexpected token `}' /usr/share/preupgrade/common.sh: line 226: `}' /usr/share/premigrate/common.sh: line 226: syntax error near unexpected token `}' /usr/share/premigrate/common.sh: line 226: `}' This is apparently caused by two bad `if` calls near the top of the `check_rpm_to()` function: check_rpm_to() { local RPM=1 local BINARY=1 local RPM_NAME=$1 local BINARY_NAME=$2 local NOT_APPLICABLE=0 if [ -z "$1" ] && RPM=0 if [ -z "$2" ] && BINARY=0 if [ $RPM -eq 1 ]; then RPM_NAME=$(echo "$RPM_NAME" | tr "," " ") for pkg in $RPM_NAME do grep "^$pkg[[:space:]]" $VALUE_RPM_QA > /dev/null if [ $? -ne 0 ]; then log_high_risk "Package $pkg is not installed" NOT_APPLICABLE=1 fi done fi if [ $BINARY -eq 1 ]; then BINARY_NAME=$(echo "$BINARY_NAME" | tr "," " ") for bin in $BINARY_NAME do which $bin > /dev/null 2>&1 if [ $? -ne 0 ]; then log_high_risk "Binary $bin is not installed" NOT_APPLICABLE=1 fi done fi if [ $NOT_APPLICABLE -eq 1 ]; then exit_fail fi } Version-Release number of selected component ============================================ preupgrade-assistant-2.1.4-9.el6.noarch How reproducible ================ Always Steps to Reproduce ================== 1. Call bash -n /usr/share/preupgrade/common.sh bash -n /usr/share/premigrate/common.sh 2. Check output Actual results ============== Syntax error Expected results ================ No errors Additional info =============== At this moment, it's also present in upstream repo (228c64c).