Bug 1309625

Summary: updated nfs-utils package broke nfsdcltrack
Product: Red Hat Enterprise Linux 7 Reporter: Libor Miksik <lmiksik>
Component: nfs-utilsAssignee: Steve Dickson <steved>
Status: CLOSED ERRATA QA Contact: Yongcheng Yang <yoyang>
Severity: high Docs Contact: Marie Hornickova <mdolezel>
Priority: urgent    
Version: 7.2CC: bcodding, bfields, bugzilla.redhat.com, dgilbert, dwysocha, eguan, fsorenso, gdubreui, green, j, knweiss, lmiksik, lslysz, luc.lalonde, mark2015, martin, mdolezel, mkolaja, pasteur, redhatbugs, sellis, steved, swhiteho, tlavigne, vanhoof, zagar
Target Milestone: rcKeywords: Patch, Regression, TestCaseProvided, ZStream
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: nfs-utils-1.3.0-0.21.el7_2.1 Doc Type: Bug Fix
Doc Text:
The update of the nfs-utils packages in Red Hat Enterprise Linux 7.2 added support for the NFSv4.1 features which was incomplete. Consequently, the NFSv4 client-tracking callout program (nfsdcltrack) created an incorrect schema for the clients table, and the file locks appeared then but these locks did not persist after restart. With this update, the underlying source code has been fixed, and nfsdcltrack can now enter the NFS client data into the database. As a result, NFS clients no longer experience the incorrect locks after NFS server restart.
Story Points: ---
Clone Of: 1285097 Environment:
Last Closed: 2016-06-23 16:31:31 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1285097    
Bug Blocks:    
Attachments:
Description Flags
Crash report none

Description Libor Miksik 2016-02-18 10:33:42 UTC
This bug has been copied from bug #1285097 and has been proposed
to be backported to 7.2 z-stream (EUS).

Comment 5 Steve Dickson 2016-04-26 18:10:46 UTC
 nfs-utils-1.3.0-0.21.el7_2 already exists... so I really don't know what to do to get this in the errata...

Comment 6 Steve Dickson 2016-05-03 15:56:32 UTC
I've done the commit
commit e3cd958a42458fdb5fdd24d15b052ca4d034965c
Author: Steve Dickson <steved>
Date:   Mon Feb 22 16:58:21 2016 -0500

    Update to nfsdcltrack v2 schema (bz 1309625)
    
    Signed-off-by: Steve Dickson <steved>
    Resolves: bz1309625

But the NVR does not increase from _2 to _3 
so the build fails with:

rhpkg build
Could not execute build: Package nfs-utils-1.3.0-0.21.el7_2 has already been built
Note: You can skip this check with --skip-nvr-check. See help for more info.
make: *** [build] Error 1

Comment 7 Jason Harper 2016-05-03 16:43:11 UTC
I'm a bit confused.  This bug is marked "Fixed In Version: nfs-utils-1.3.0-0.21.el7_2" but advisory RHBA-2016:0206-1does not mention that it includes the fix for this issue.  Is it fixed in nfs-utils-1.3.0-0.21.el7_2 or not?  If not, why is this bug marked that it is?

Comment 8 Marcel Kolaja 2016-05-04 16:00:41 UTC
(In reply to Steve Dickson from comment #6)
> I've done the commit
> commit e3cd958a42458fdb5fdd24d15b052ca4d034965c
> Author: Steve Dickson <steved>
> Date:   Mon Feb 22 16:58:21 2016 -0500
> 
>     Update to nfsdcltrack v2 schema (bz 1309625)
>     
>     Signed-off-by: Steve Dickson <steved>
>     Resolves: bz1309625
> 
> But the NVR does not increase from _2 to _3 
> so the build fails with:
> 
> rhpkg build
> Could not execute build: Package nfs-utils-1.3.0-0.21.el7_2 has already been
> built
> Note: You can skip this check with --skip-nvr-check. See help for more info.
> make: *** [build] Error 1

As in bug #1325769, I suspect that the Release in the spec file needs to be incremented. Could that be the problem, Steve? Thanks!

Comment 9 Steve Dickson 2016-05-04 21:36:48 UTC
Again, how do I update the Release: to make this happen?

Comment 10 Marcel Kolaja 2016-05-06 11:57:03 UTC
(In reply to Steve Dickson from comment #9)
> Again, how do I update the Release: to make this happen?

I _think_ it should be:

Release: 0.22%{?dist}

Or anything that fits your versioning scheme. Does it make sense this way?

Comment 11 Steve Dickson 2016-05-06 13:34:12 UTC
(In reply to Marcel Kolaja from comment #10)
> (In reply to Steve Dickson from comment #9)
> > Again, how do I update the Release: to make this happen?
> 
> I _think_ it should be:
> 
> Release: 0.22%{?dist}
> 
> Or anything that fits your versioning scheme. Does it make sense this way?

As I said in the othr bz... the original released NVR has to be persevere
THe _# is Z-stream version.

Comment 12 Marcel Kolaja 2016-05-09 14:21:36 UTC
(In reply to Steve Dickson from comment #11)
> (In reply to Marcel Kolaja from comment #10)
> > (In reply to Steve Dickson from comment #9)
> > > Again, how do I update the Release: to make this happen?
> > 
> > I _think_ it should be:
> > 
> > Release: 0.22%{?dist}
> > 
> > Or anything that fits your versioning scheme. Does it make sense this way?
> 
> As I said in the othr bz... the original released NVR has to be persevere
> THe _# is Z-stream version.

Similarly as in the other bug, yes, it's shouldn't be 0.22%{?dist}. Sorry for that. Does this work?

Release: 0.21%{?dist}.1

Comment 13 Luc Lalonde 2016-05-10 14:47:23 UTC
This is not fixed... I'm still getting the error with nfs-utils-1.3.0-0.21.el7_2:

May 10 10:44:51 nfs4-server nfsdcltrack[29235]: sqlite_insert_client: insert statement prepare failed: table clients has 2 columns but 3 values were supplied

I'm also wondering if it's related to an ABRT crash report I've recently received.  I'll post the report as an attachment.

Comment 14 Luc Lalonde 2016-05-10 14:50:45 UTC
Created attachment 1155774 [details]
Crash report

I don't know if this is related to this issue...

Comment 17 Yongcheng Yang 2016-05-19 03:05:43 UTC
Move to VERIFIED according to comment 16

Comment 19 errata-xmlrpc 2016-06-23 16:31:31 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1258