| Summary: | [RFE] Enhance the functionality of add_disk for adv configs | ||
|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Josh Carter <jocarter> |
| Component: | Automate | Assignee: | Moti Asayag <masayag> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Milan Falešník <mfalesni> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 5.5.0 | CC: | cbolz, dajohnso, ealcaniz, fdewaley, gekis, gmccullo, jhardy, masayag, mfalesni, mkanoor, obarenbo, simaishi, tfitzger |
| Target Milestone: | GA | Keywords: | FutureFeature, TestOnly |
| Target Release: | 5.8.0 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | automate | ||
| Fixed In Version: | 5.8.0.0 | Doc Type: | Enhancement |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-06-12 16:08:37 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Comment 2
Greg McCullough
2016-02-25 14:45:46 UTC
Related bugs: Bug 1130060 - Support thin_provision flag. Bug 1311221 - Support independent-persistent flags. We need an update about this RFE please? No update I can provide from the build side, as this hasn't been fixed yet. Based on the flags set on this bug, it's not targeted for cfme 5.7. Please check with GregM for the status. Thanks for the update, Greg could you give more details please. David could you update the progress of the RFE please Dave could you update the progress of the RFE please Adding disks has been implemented in PR https://github.com/ManageIQ/manageiq/pull/13318 for bug 1123068. bug 1414893 is the 5.7.z clone of bug 1123068 (In reply to Greg McCullough from comment #15) > Adding disks has been implemented in PR > https://github.com/ManageIQ/manageiq/pull/13318 for bug 1123068. This is for RHEV and customer use VMware, this RFE was created for VMware. Edu - VMware already supports these options. Could you give us an update please. Verified in 5.8.0.7 against RHEV 4.0
I executed this against a vm in automate:
vm.add_disk('testdisk2', 1536, :thin_provisioned => true)
and the disk got added as expected.
This feature throws a nil class exception in the log when used with RHEV 3.6 and the exception is not user-handleable. Should it either work or should it be posible to handle it?
(In reply to Milan Falešník from comment #22) > Verified in 5.8.0.7 against RHEV 4.0 > > I executed this against a vm in automate: > > vm.add_disk('testdisk2', 1536, :thin_provisioned => true) > > and the disk got added as expected. > > This feature throws a nil class exception in the log when used with RHEV 3.6 > and the exception is not user-handleable. Should it either work or should it > be possible to handle it? RHEV 3.6 doesn't support disk attachments, therefore it shouldn't work for 3.6 hosts. However, this issue should be tracked by Bug 1123068. Could you comment there and attach the exception from log to that bug ? (In reply to Moti Asayag from comment #23) > (In reply to Milan Falešník from comment #22) > > Verified in 5.8.0.7 against RHEV 4.0 > > > > I executed this against a vm in automate: > > > > vm.add_disk('testdisk2', 1536, :thin_provisioned => true) > > > > and the disk got added as expected. > > > > This feature throws a nil class exception in the log when used with RHEV 3.6 > > and the exception is not user-handleable. Should it either work or should it > > be possible to handle it? > > RHEV 3.6 doesn't support disk attachments, therefore it shouldn't work for > 3.6 hosts. > > However, this issue should be tracked by Bug 1123068. > Could you comment there and attach the exception from log to that bug ? Hi, my customer only works with VMware. if you need any test let me know. |