Bug 1310074

Summary: Importing external network with name duplicated by existing network causes unhandled UI error
Product: [oVirt] ovirt-engine Reporter: Marcin Mirecki <mmirecki>
Component: Frontend.WebAdminAssignee: Dominik Holler <dholler>
Status: CLOSED NOTABUG QA Contact: Pavel Stehlik <pstehlik>
Severity: low Docs Contact:
Priority: low    
Version: 3.6.0CC: bugs, danken
Target Milestone: ovirt-4.1.0-alphaFlags: danken: ovirt-4.1?
rule-engine: planning_ack?
rule-engine: devel_ack?
rule-engine: testing_ack?
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-11-10 15:25:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Error message none

Description Marcin Mirecki 2016-02-19 11:39:37 UTC
Importing external network with name duplicated by existing network causes unhandled UI error

When a network from an external provider is imported, and there already exists a network with such a name in the system, the UI breaks due to an unhandled error.

Steps to Reproduce:
1. Create network <network_name> in ovirt.
2. Add external network provider containing a network <network_name>.
3. Open external networks import dialog.
4. Try to import the network with duplicated name <network_name>
5. Unhandled GWT exception occurs.
 
Cause:

ImportNetworksModel.onProviderChosen -> onSuccess(Object model, Object returnValue)  line 153
The return value passed in, is a map external_network:{set of data centers}
For a duplicated network {set of data centers} is empty, which will cause an NPE exception when the Import button is pressed.
This will be in:
ImportNetworksModel.onImport (line 244) -> externalNetwork.getDataCenters().getSelectedItem()

Comment 1 Marcin Mirecki 2016-02-19 11:41:06 UTC
*** Bug 1310071 has been marked as a duplicate of this bug. ***

Comment 2 Sandro Bonazzola 2016-05-02 10:06:33 UTC
Moving from 4.0 alpha to 4.0 beta since 4.0 alpha has been already released and bug is not ON_QA.

Comment 3 Yaniv Lavi 2016-05-23 13:21:22 UTC
oVirt 4.0 beta has been released, moving to RC milestone.

Comment 4 Yaniv Lavi 2016-05-23 13:24:15 UTC
oVirt 4.0 beta has been released, moving to RC milestone.

Comment 5 Dominik Holler 2016-11-10 15:23:56 UTC
Created attachment 1219452 [details]
Error message

Comment 6 Dominik Holler 2016-11-10 15:25:51 UTC
The attemt to reproduce this bug results in a error message, see  attachment 1219452 [details]. So this bug seems to be fixed already.