Bug 1310550

Summary: [kde-l10n] Please add Supplements tag in specfile
Product: [Fedora] Fedora Reporter: Parag Nemade <pnemade>
Component: kde-l10nAssignee: Than Ngo <than>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: ltinkl, pnemade, rdieter, rnovacek, smparrish, than
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-03-23 11:59:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1314406    
Attachments:
Description Flags
Add Supplements for langpacks namimg guidelines none

Description Parag Nemade 2016-02-22 08:29:16 UTC 
Created attachment 1129181 [details]
Add Supplements for langpacks namimg guidelines

Description of problem:
As per newly approved https://fedoraproject.org/wiki/PackagingDrafts/Langpack guidelines in https://fedorahosted.org/fpc/ticket/593#comment:18 , I would like to request to please commit the attached patch so that langpacks installation will be helpful.
Comment 1 Rex Dieter 2016-02-23 17:42:20 UTC 
I didn't realize Rich dependencies were sanctioned yet, I assume this is a f24+ only change?

Any objection to my conditionally wrapping things like:

%if 0%{?fedora} > 23
Supplements: (%{name} = %{version}-%{release} and langpacks-ar)
%endif

??
Comment 2 Rex Dieter 2016-02-23 20:10:22 UTC 
speaking with tibbs, we're pretty sure it should be safe for f23+ at least, and we're not going to be backporting this version of f22 (most likely), so should be safe as-is
Comment 3 Parag Nemade 2016-02-24 05:47:06 UTC 
Rex, Thanks for your help in committing required changes.
Comment 4 Rex Dieter 2016-03-23 11:58:30 UTC 
Looking at this closer, I wonder why you want rich-deps here at all, why is this simpler:

Supplements: langpacks-foo

not sufficient?
Comment 5 Rex Dieter 2016-03-23 11:59:49 UTC 
Ah, nevermind, we don't want this pulled in unconditionally, that's why.

That said, I think we could consider making the conditional on something better than kde-l10n... I'll think more on it.
Comment 6 Parag Nemade 2016-03-23 12:02:17 UTC 
Thank you for understanding the use here for langpacks functionality. Like calligra-l10n, if needed conditionals can be added here as well.