Bug 1311097

Summary: EAP7 - name and type is the same as EAP6 which could be confusing
Product: [JBoss] JBoss Operations Network Reporter: Filip Brychta <fbrychta>
Component: Plugin -- JBoss EAP 7, UsabilityAssignee: Michael Burman <miburman>
Status: CLOSED CURRENTRELEASE QA Contact: Filip Brychta <fbrychta>
Severity: high Docs Contact:
Priority: high    
Version: JON 3.3.5CC: hrupp, jdoyle, loleary, miburman, spinder
Target Milestone: DR01Keywords: Triaged
Target Release: One-off release   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-06-06 18:58:11 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1314853    
Attachments:
Description Flags
servers screen shot none

Description Filip Brychta 2016-02-23 11:49:28 UTC
Created attachment 1129725 [details]
servers screen shot

Description of problem:
This is just usability issue. See attached screen shot.
It's possible to differentiate between EAP6 and EAP7 by description and version column but name and type are the same. Especially type "JBossAS7 Standalone Server" could be misleading since EAP7 is not based on JBossAS7

Version-Release number of selected component (if applicable):
JON3.3.5 with eap plugin pack update03.DR01

How reproducible:
Always

Comment 2 Michael Burman 2016-02-29 13:57:02 UTC
Type is coming from a plugin descriptor and would require separate plugin for EAP7 to be separated from the EAP6. Name field could be customized by making special string formatting for EAP7.

Requires changing StandaloneASDiscovery buildDefaultResourceName() and ManagedASDiscovery and HostControllerDiscovery classes, as the naming scheme comes automatically from JBossProductType using SHORT_NAME (which can't be changed, it must remain EAP for EAP7 also).

Comment 3 Michael Burman 2016-02-29 13:58:30 UTC
What would be the preferred name? EAP7 (127.0.0.1) or something else?

Comment 4 Michael Burman 2016-03-02 11:57:12 UTC
Type is now changed in the eap7dr02 branch. Name field format must be still decided.

Comment 5 Heiko W. Rupp 2016-03-02 12:35:29 UTC
As far as I recall, we do not have name + display name for resource types.
Which means the name shown is the name of the type that is used not only for display purposes, but also for "internal computations" and in dynagroup expressions and so on.

We can not change this in the *existing eap6 plugin* for the existing types that exist without a huge amount of work, db-upgrade and a huge risk.

Also existing customers with eap6 are used to the fact that eap6 is of type "JBossAS7 Standalone Server".

Having said that, we can going forward (as Michael wrote) provide a new type name "Standalone EAP7 server" for EAP7 servers(only).

@John D. can you come up with a name you like?

Comment 6 John Doyle 2016-03-02 13:42:52 UTC
Let's use the following names for the EAP 7 managed resources.

EAP 7 Standalone Server
EAP 7 Domain Controller
EAP 7 Host Controller

Comment 7 Michael Burman 2016-03-03 17:23:27 UTC
Fixed in the master (type was fixed in the initial commit of the plugin):

commit 1d2e5c936866a6442cc63104ec6b5349c021389f
Author: Michael Burman <miburman>
Date:   Thu Mar 3 19:22:24 2016 +0200

    [BZ 1311097] Change resource name from EAP (%s ..) to EAP 7 (%s ..)

Comment 10 Filip Brychta 2016-03-23 09:24:10 UTC
Verified on update04 DR01