Bug 1311407
Summary: | glusterfs : fix double free possibility in the code | ||
---|---|---|---|
Product: | [Community] GlusterFS | Reporter: | Jiffin <jthottan> |
Component: | core | Assignee: | Jiffin <jthottan> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 3.7.9 | CC: | bugs |
Target Milestone: | --- | Keywords: | EasyFix, Triaged |
Target Release: | --- | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
Fixed In Version: | glusterfs-3.7.15 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | 1247603 | Environment: | |
Last Closed: | 2016-09-01 09:20:35 UTC | Type: | Bug |
Regression: | --- | Mount Type: | All |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1247603 | ||
Bug Blocks: | 1309567 |
Description
Jiffin
2016-02-24 08:01:55 UTC
REVIEW: http://review.gluster.org/13505 (gfapi : Avoid double freeing of dict in glfs_*_*getxattr) posted (#1) for review on release-3.7 by jiffin tony Thottan (jthottan) This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions REVIEW: http://review.gluster.org/13505 (gfapi : Avoid double freeing of dict in glfs_*_*getxattr) posted (#2) for review on release-3.7 by jiffin tony Thottan (jthottan) REVIEW: http://review.gluster.org/13505 (gfapi : Avoid double freeing of dict in glfs_*_*getxattr) posted (#3) for review on release-3.7 by Oleksandr Natalenko (oleksandr) COMMIT: http://review.gluster.org/13505 committed in release-3.7 by Niels de Vos (ndevos) ------ commit 102b565fd867b7ef721b481aeb6c8c39d904ecec Author: Jiffin Tony Thottan <jthottan> Date: Mon Feb 22 17:20:58 2016 +0530 gfapi : Avoid double freeing of dict in glfs_*_*getxattr The dict variable "xattr" is passed to glfs_getxattr_process() and glfs_listxattr_process() in glfs_*_*getxattrs(). This variable is unrefed by both functions and again in caller function which may result in segfault. So it is wrong to call dict_unref() in both glfs_*xattr_process functions. Backport reference : >Change-Id: I227f55ebc3169f58910863c04ae536a8d789e80e >BUG: 1247603 Signed-off-by: Jiffin Tony Thottan <jthottan> >Reviewed-on: http://review.gluster.org/13483 >Smoke: Gluster Build System <jenkins.com> >NetBSD-regression: NetBSD Build System <jenkins.org> >CentOS-regression: Gluster Build System <jenkins.com> >Reviewed-by: Niels de Vos <ndevos> Change-Id: I2e574ff4b7a095749540bdb9d3593bc1d6275e56 BUG: 1311407 Signed-off-by: Jiffin Tony Thottan <jthottan> Signed-off-by: Oleksandr Natalenko <oleksandr> Reviewed-on: http://review.gluster.org/13505 Reviewed-by: Prashanth Pai <ppai> NetBSD-regression: NetBSD Build System <jenkins.org> Smoke: Gluster Build System <jenkins.org> Reviewed-by: Niels de Vos <ndevos> CentOS-regression: Gluster Build System <jenkins.org> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.15, please open a new bug report. glusterfs-3.7.15 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] https://www.gluster.org/pipermail/gluster-devel/2016-September/050714.html [2] https://www.gluster.org/pipermail/gluster-users/ This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.15, please open a new bug report. glusterfs-3.7.15 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] https://www.gluster.org/pipermail/gluster-devel/2016-September/050714.html [2] https://www.gluster.org/pipermail/gluster-users/ |