Bug 1311515
Summary: | python-cinderclient: Provide a Python 3 subpackage | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Tomas Orsava <torsava> | ||||||||
Component: | python-cinderclient | Assignee: | Haïkel Guémar <karlthered> | ||||||||
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
Severity: | unspecified | Docs Contact: | |||||||||
Priority: | unspecified | ||||||||||
Version: | 25 | CC: | apevec, eharney, jruzicka, karlthered, lbalhar, pronix.service | ||||||||
Target Milestone: | --- | ||||||||||
Target Release: | --- | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Whiteboard: | |||||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||||
Doc Text: | Story Points: | --- | |||||||||
Clone Of: | Environment: | ||||||||||
Last Closed: | 2016-08-17 13:22:59 UTC | Type: | Bug | ||||||||
Regression: | --- | Mount Type: | --- | ||||||||
Documentation: | --- | CRM: | |||||||||
Verified Versions: | Category: | --- | |||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||
Embargoed: | |||||||||||
Bug Depends On: | |||||||||||
Bug Blocks: | 1285816, 1312032 | ||||||||||
Attachments: |
|
Description
Tomas Orsava
2016-02-24 11:49:55 UTC
Created attachment 1180386 [details]
0001-pytho3-subpackages.patch
hello
i add subpackages for python2 and python3.
is it correct way change name for subpackage for python2 from python-cinderclient to python2-cinderclient ?
how can i help for speed up process ? may be you need co-maintainer ? This bug appears to have been reported against 'rawhide' during the Fedora 25 development cycle. Changing version to '25'. Hello. Thank you very much for your work. I am reviewing your patch and there are some issues which I mentioned in previous reviews (like global definition for srcname). This package is application with some executable in %{_bindir} so it needs different approach. In current specfile you have python2 installation first which creates %{_bindir}/cinder and then python3 installation which replace this file with version built with python3. This means that you will have version buit with python3 in python2 subpackage. You should move this file to other location after one installation process and then create some symlinks. Everything is explained in this part of guideline: http://python-rpm-porting.readthedocs.io/en/latest/application-modules.html My other suggestions: - You should add description to subpackages (You can use global definition as well) - For documentation, you need only Python3 dependencies and documentation needs to be built only once with sphinx-build-3. In current specfile documentation is built first time with sphinx for Python2 and then replaced by build with sphinx for Python3. - Please, use %license macro in the files section for license files instead of %doc. - There isn't changelog entry for your changes. Thank you and have a nice day. Created attachment 1186162 [details]
py3 subpackage
added changes after review
Hello. Thanks for updated patch. There are still some issues: - Increment release number - Be more specific in BuildRequires and Requires - python2-pbr instead python-pbr. - Maybe it would be better to use some global macros for 'cinder' and 'cinderclient'. Your approach to handling binary files looks correct but please consider to use standard symlinks for both pythons version like cinder-2, cinder-2.7, cinder-3, cinder-3.5 mentioned in the guideline for this type of software. Have a nice day. For more detailed instructions how to properly setup these symlinks, refer to this section [0] of the Python RPM Porting guide. [0] http://python-rpm-porting.readthedocs.io/en/latest/tools.html#moving-the-executables-and-making-symlinks Created attachment 1190159 [details]
0001-pytho3-subpackages
spicified deps and fix links for subpackages
Hello Dmitry. Specfile looks good but you should use preferred way to handle executables mentioned in guide instead of making symlinks in %post sections because this way is not deterministic. Thank you for your effort. Fixed in rawhide. I don't like using scriptlets for creating default symlink. But since upstream still recommends python2 as default interpreter, cinder is a symlink to python2 version. Btw, it will be at some point deprecated by openstackclient and this package will only ship a plugin to the former. |