Bug 131190

Summary: pam_limits misses support for new limits in 2.6 kernel
Product: [Fedora] Fedora Reporter: Ulrich Drepper <drepper>
Component: pamAssignee: Tomas Mraz <tmraz>
Status: CLOSED UPSTREAM QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 3CC: dgunchev, redhat-bugzilla, toby
Target Milestone: ---Keywords: FutureFeature
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-01-07 12:21:13 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Attachments:
Description Flags
adds sigpending and mqueue params to pam_limits
none
adds sigpending and mqueue params to pam_limits
none
Patch applied to upstream none

Description Ulrich Drepper 2004-08-28 18:08:29 UTC
Description of problem:
The 2.6 kernel supports two new limits, RLIMIT_SIGPENDING and
RLIMIT_MSGQUEUE.  Supporting them is potentially really important some
applications might not run with the default limits and on many-user
machines the defaults are likely too high.

Version-Release number of selected component (if applicable):
pam-0.77-54

How reproducible:
always

Steps to Reproduce:
1.well, read PAM docs and sources
2.
3.
  
Actual results:
Support not there

Expected results:
Support sigpending and mqueue limits

Additional info:
bash-3.0-8 has support for these limits so checking whether the code
works is easy.

Comment 1 toby cabot 2004-12-21 23:02:37 UTC
Created attachment 108984 [details]
adds sigpending and mqueue params to pam_limits

hi, here's a patch that adds two parameters to pam_limits.c so you can set the
limits on pending signals and POSIX queue memory.  It applies against 0.77
(which is what my system is running) but looks like it should apply against
0.78 also.

Comment 2 toby cabot 2004-12-21 23:03:11 UTC
Created attachment 108985 [details]
adds sigpending and mqueue params to pam_limits

hi, here's a patch that adds two parameters to pam_limits.c so you can set the
limits on pending signals and POSIX queue memory.  It applies against 0.77
(which is what my system is running) but looks like it should apply against
0.78 also.

Comment 3 Ulrich Drepper 2004-12-21 23:18:08 UTC
Comment on attachment 108984 [details]
adds sigpending and mqueue params to pam_limits

one copy is enough

Comment 4 Ulrich Drepper 2004-12-21 23:25:18 UTC
Comment on attachment 108984 [details]
adds sigpending and mqueue params to pam_limits

one copy is enough

Comment 5 Ulrich Drepper 2004-12-21 23:33:30 UTC
The patch looks OK, although you might need #ifdefs the new code.

The problem is, though, that this is a change inthe configuration file format. 
I cannot speak for Tomas, but I wouldn't accept the patch unless it is blessed
by upstream.  Otherwise the upstream maintainer might use different keywords and
then the config files are incompatible.

Comment 6 Tomas Mraz 2004-12-25 19:52:52 UTC
As I am one of the upstream maintainers, this shouldn't be a problem.

Comment 7 Tomas Mraz 2005-01-07 12:21:13 UTC
OK, I've commited that to upstream CVS however I've actually decided to rename
the mqueue to msgqueue as all the other limits use the same name as in
RLIMIT_xxxx defines. And I added the #ifdefs.


Comment 8 Tomas Mraz 2005-01-07 12:25:10 UTC
Created attachment 109462 [details]
Patch applied to upstream

Comment 9 toby cabot 2005-01-07 13:11:02 UTC
thanks Tomas!