Bug 1311904

Summary:	cannot add members to beaker group on Google Chrome
Product:	[Retired] Beaker	Reporter:	Linqing Lu <lilu>
Component:	general	Assignee:	matt jia <mjia>
Status:	CLOSED CURRENTRELEASE	QA Contact:	tools-bugs <tools-bugs>
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	22	CC:	dcallagh, dowang, lilu, mjia, rjoost
Target Milestone:	22.2	Keywords:	Patch
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-03-15 01:51:16 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Linqing Lu 2016-02-25 10:01:36 UTC

Description of problem:
As a group owner, I tried to add new members to an existing beaker group but failed.

Version-Release number of selected component (if applicable):
22.1

How reproducible:
always

Steps to Reproduce:
1. go to beaker group member page - e.g. https://beaker.engineering.redhat.com/groups/kernel-general-qe
2. input user krb id in "Username" field and select the right one from filtered list
3. click "+ Add"

Actual results:
page reloaded but group member list remained the same, no warning/error message either

Expected results:
new member got added into group member list

Additional info:

Comment 1 matt jia 2016-02-25 22:16:43 UTC

(In reply to Linqing Lu from comment #0)
> Description of problem:
> As a group owner, I tried to add new members to an existing beaker group but
> failed.
> 
> Version-Release number of selected component (if applicable):
> 22.1
> 
> How reproducible:
> always
> 
> Steps to Reproduce:
> 1. go to beaker group member page - e.g.
> https://beaker.engineering.redhat.com/groups/kernel-general-qe
> 2. input user krb id in "Username" field and select the right one from
> filtered list
> 3. click "+ Add"
> 
> Actual results:
> page reloaded but group member list remained the same, no warning/error
> message either
> 
> Expected results:
> new member got added into group member list
> 
> Additional info:

Hi Linqing Lu,

Thank you for reporting but I cannot reproduce it. There is no user with user id krb. Could you please provide more information?

Thanks

Comment 3 Linqing Lu 2016-02-26 02:55:05 UTC

Besides, the browser was Chrome v44.

Comment 4 matt jia 2016-02-26 03:23:00 UTC

(In reply to Linqing Lu from comment #3)
> Besides, the browser was Chrome v44.

Okay, we donnot actually support Chrome very well as we think most of the users are using firefox. I have tried it on firefox and it works so please use it as a workaround.

Comment 5 matt jia 2016-02-29 00:41:17 UTC

On Gerrit:

   http://gerrit.beaker-project.org/#/c/4699/

Comment 6 Dan Callaghan 2016-02-29 03:56:47 UTC

So the problem was we were using some ES6 features not supported by Chrome 44. We can fix it in this case easily but I think we are relying on ES6 support in other parts of Beaker's web UI, and will continue to do so more and more since all the supported releases of the major browsers support ES6 now.

Bear in mind that Chrome 44 is several releases out of date and is unsupported by Google, so you should consider upgrading.

Comment 7 matt jia 2016-02-29 04:03:05 UTC

(In reply to Dan Callaghan from comment #6)
> So the problem was we were using some ES6 features not supported by Chrome
> 44. We can fix it in this case easily but I think we are relying on ES6
> support in other parts of Beaker's web UI, and will continue to do so more
> and more since all the supported releases of the major browsers support ES6
> now.
> 
> Bear in mind that Chrome 44 is several releases out of date and is
> unsupported by Google, so you should consider upgrading.

Yes, we are using Array.find() from ES6 which is not supported by Chrome 44. In my above patch, I change it to underscore.find() that fixes the problem.

Comment 10 Dan Callaghan 2016-03-15 01:51:16 UTC

Beaker 22.2 has been released.