Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1312052

Summary:

NSSProtocol is ignored when NSSFIPS is enabled.

Product:

Red Hat Enterprise Linux 6

Reporter:

Robert Bost <rbost>

Component:

mod_nss

Assignee:

Matthew Harmsen <mharmsen>

Status:

CLOSED ERRATA

QA Contact:

Kaleem <ksiddiqu>

Severity:

unspecified

Docs Contact:

Priority:

urgent

Version:

6.7

CC:

akasurde, dmasirka, dpal, hokuda, rcritten

Target Milestone:

Keywords:

ZStream

Target Release:

---

Hardware:

Unspecified

OS:

Unspecified

Whiteboard:

Fixed In Version:

mod_nss-1.0.10-6.el6

Doc Type:

Bug Fix

Doc Text:

Story Points:

---

Clone Of:

Clones:

1312491 1322304 (view as bug list)

Environment:

Last Closed:

2016-05-10 19:41:37 UTC

Type:

Bug

Regression:

---

Mount Type:

---

Documentation:

---

CRM:

Verified Versions:

Category:

---

oVirt Team:

---

RHEL 7.3 requirements from Atomic Host:

Cloudforms Team:

---

Target Upstream Version:

Embargoed:

Bug Depends On:

Bug Blocks:

1312491, 1322304

Attachments:

Description	Flags
Patch for rhbz #1312052 - NSSProtocol is ignored when NSSFIPS is enabled.	rcritten: review-
mod_nss.spec file diffs for rhbz #1312052 - NSSProtocol is ignored when NSSFIPS is enabled.	rcritten: review+
Patch for rhbz #1312052 - NSSProtocol is ignored when NSSFIPS is enabled.	rcritten: review+
console.log	none
httpd_error_access_log	none

Description Robert Bost 2016-02-25 15:56:08 UTC

Description of problem: When I have NSSFIPS enabled/On, any settings I have in NSSProtocol are ignored. This presents an issue when I only want to use TLSv1.2 and exclude TLSv1.0 and TLSv1.1.

When NSSFIPS is enabled/On it forces TLSv1.0->1.2 to be used as protocols.


Version-Release number of selected component (if applicable): mod_nss-1.0.10-1.el6.x86_64


How reproducible: Always.


Steps to Reproduce:
1. Set NSSFIPS On
2. Set NSSProtocol TLSv1.2
3. Make request like `curl --tlsv1.0 https://localhost:8443/`

Actual results: curl using TLSv1.0 succeeds.


Expected results: curl using TLSv1.0 would have SSL Handshake failure due to no overlapping protocols.


Additional info:
This may be an invalid bug report if FIPS requires TLSv1.0->1.2 to be used. Is the ability to use _only_ TLSv1.2 valid in terms of FIPS compliance?

nss_engine_init.c:596
if (mctx->sc->fips) {                                                                                                                                                                
    ap_log_error(APLOG_MARK, APLOG_INFO, 0, s,                                                                                                                                       
        "In FIPS mode ignoring %s list, enabling TLSv1.0, TLSv1.1 and TLSv1.2",                                                                                                      
        protocol_marker);                                                                                                                                                            
    tls = tls1_1 = tls1_2 = 1;                                                                                                                                                       
}

Comment 2 Rob Crittenden 2016-02-25 20:38:04 UTC

I think the intention originally was to only allow TLSv1 and disable SSL2 and 3. This was before the range code and TLS 1.1 and 1.2 support. I think this just needs to be set the minimum range to TLS 1.0 by default and let NSSProtocol override it for higher values.

I don't see a configuration workaround.

Comment 3 Matthew Harmsen 2016-02-26 03:12:32 UTC

Created attachment 1130696 [details]
Patch for rhbz #1312052 - NSSProtocol is ignored when NSSFIPS is enabled.

Comment 4 Matthew Harmsen 2016-02-26 03:14:07 UTC

Created attachment 1130697 [details]
mod_nss.spec file diffs for rhbz #1312052 - NSSProtocol is ignored when NSSFIPS is enabled.

Comment 5 Matthew Harmsen 2016-02-26 03:15:25 UTC

I compiled and performed some minimal testing per the procedure documented in the initial description.

Comment 6 Rob Crittenden 2016-02-26 17:14:13 UTC

Comment on attachment 1130696 [details]
Patch for rhbz #1312052 - NSSProtocol is ignored when NSSFIPS is enabled.

Functionally it is ok, I just have a few suggestions:

1. I think the initial "if (mctx->sc->fips)" check can be removed completely. I don't know that we learn anything by retaining it other than it detected we're in FIPS mode.

2. For the SSL2 and SSL3 checks rather than just logging "Disabling SSL[23]" I'd log that SSL[23] is disabled by FIPS policy or something like that.

3. For the final catch-all in FIPS mode for the case where no valid protocols were provided I'd change the log message to reflect that, something like:

"%s: FIPS mode no valid protocols set, enabling TLSv1.0, TLSv1.1 and TLSv1.2",
                protocol_marker

Comment 7 Matthew Harmsen 2016-02-26 18:45:18 UTC

(In reply to Rob Crittenden from comment #6)
> Comment on attachment 1130696 [details]
> Patch for rhbz #1312052 - NSSProtocol is ignored when NSSFIPS is enabled.
> 
> Functionally it is ok, I just have a few suggestions:
> 
> 1. I think the initial "if (mctx->sc->fips)" check can be removed
> completely. I don't know that we learn anything by retaining it other than
> it detected we're in FIPS mode.
> 

DONE

> 2. For the SSL2 and SSL3 checks rather than just logging "Disabling SSL[23]"
> I'd log that SSL[23] is disabled by FIPS policy or something like that.
> 

QUESTION:  Should these FIPS messages be marked as WARNING or INFO instead of DEBUG?

> 3. For the final catch-all in FIPS mode for the case where no valid
> protocols were provided I'd change the log message to reflect that,
> something like:
> 
> "%s: FIPS mode no valid protocols set, enabling TLSv1.0, TLSv1.1 and
> TLSv1.2",
>                 protocol_marker

QUESTION:  Should this message be marked as WARNING rather than INFO?

Comment 8 Rob Crittenden 2016-02-26 19:29:03 UTC

I think WARNING for the first, INFO for the second.

Comment 9 Matthew Harmsen 2016-02-26 20:14:06 UTC

Created attachment 1130895 [details]
Patch for rhbz #1312052 - NSSProtocol is ignored when NSSFIPS is enabled.

Attached revised patch for your review.

Once again, I ran a number of tests to make certain that it still works.

Comment 10 Rob Crittenden 2016-02-26 20:19:08 UTC

Comment on attachment 1130697 [details]
mod_nss.spec file diffs for rhbz #1312052 - NSSProtocol is ignored when NSSFIPS is enabled.

LGTM

Comment 12 Abhijeet Kasurde 2016-03-03 13:49:29 UTC

Verified using mod_nss ::
mod_nss-1.0.10-6.el6.x86_64

Please see attachments for verification steps and console.log.

Comment 13 Abhijeet Kasurde 2016-03-03 13:49:57 UTC

Created attachment 1132791 [details]
console.log

Comment 14 Abhijeet Kasurde 2016-03-03 13:50:23 UTC

Created attachment 1132792 [details]
httpd_error_access_log

Comment 18 errata-xmlrpc 2016-05-10 19:41:37 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-0751.html