Bug 1312101

Summary:	Don't allow submission of container-build without commits pushed to remote repo
Product:	[Fedora] Fedora	Reporter:	Pavol Babinčák <pbabinca>
Component:	rpkg	Assignee:	Dennis Gilmore <dennis>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	23	CC:	araszka, bochecha, dennis, hchen, lsedlar, pbabinca, s
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-03-14 10:04:09 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Pavol Babinčák 2016-02-25 17:57:59 UTC

Description of problem:
*rpkg normally doesn't allow people to submit non-scratch (rpm) builds without having commits already pushed to remove server.

container-build seems to allow that.


See error which was caused by this on server side: https://github.com/release-engineering/koji-containerbuild/issues/18

Comment 1 Ales Raszka 2016-03-02 14:11:10 UTC

Pull-request: https://pagure.io/rpkg/pull-request/35

Comment 2 Lubomír Sedlář 2016-03-02 15:03:44 UTC

Interesting thing is that the check is already there and should have prevented the build from being submitted:

https://pagure.io/rpkg/blob/master/f/src/pyrpkg/__init__.py#_2463-2464

What versions of of rhpkg and pyrpkg were used to get that error? Huemin, could you please post output of

    rpm -q rhpkg pyrpkg

Comment 3 hchen 2016-03-02 15:12:15 UTC

I don't have the environment any more. My laptop just got upgraded from RHEL 6 CSB to RHEL 7.

Comment 4 Lubomír Sedlář 2016-03-03 08:59:27 UTC

Thanks, RHEL 6 CSB is enough information, as it turns out the fixed version of rpkg was not built yet.