Bug 1312200
Summary: | Handle negative fcntl flock->l_len values | ||
---|---|---|---|
Product: | [Community] GlusterFS | Reporter: | Soumya Koduri <skoduri> |
Component: | locks | Assignee: | Soumya Koduri <skoduri> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | |
Severity: | urgent | Docs Contact: | |
Priority: | unspecified | ||
Version: | 3.7.9 | CC: | bugs, pkarampu |
Target Milestone: | --- | Keywords: | Triaged |
Target Release: | --- | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
Fixed In Version: | glusterfs-3.7.9 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | 1241104 | Environment: | |
Last Closed: | 2016-04-19 07:22:46 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1241104 | ||
Bug Blocks: |
Description
Soumya Koduri
2016-02-26 05:12:39 UTC
REVIEW: http://review.gluster.org/13526 (locks: Handle negative values for flock->l_len) posted (#1) for review on release-3.7 by soumya k (skoduri) REVIEW: http://review.gluster.org/13526 (locks: Handle negative values for flock->l_len) posted (#2) for review on release-3.7 by soumya k (skoduri) COMMIT: http://review.gluster.org/13526 committed in release-3.7 by Kaleb KEITHLEY (kkeithle) ------ commit 7e65e1b5a9a7bdaa7ca28bc5c1773bc5472f19af Author: Soumya Koduri <skoduri> Date: Fri Jul 10 12:40:24 2015 +0530 locks: Handle negative values for flock->l_len As per 'man 3 fcntl', "If l_len is positive, the area affected shall start at l_start and end at l_start+l_len−1. If l_len is negative, the area affected shall start at l_start+l_len and end at l_start−1. Locks may start and extend beyond the current end of a file, but shall not extend before the beginning of the file." Currently we return EINVAL if l_len is found to be negative. Fixed the same as mentioned in the man page. This is backport of the below patch - http://review.gluster.org/11613 Change-Id: I493ce202c543185fc4ae7266d1aaf9d7e2a66991 BUG: 1312200 Signed-off-by: Soumya Koduri <skoduri> Reviewed-on: http://review.gluster.org/11613 Reviewed-by: Kaleb KEITHLEY <kkeithle> Reviewed-by: Niels de Vos <ndevos> Reviewed-by: Raghavendra G <rgowdapp> Reviewed-on: http://review.gluster.org/13526 Smoke: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.com> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.9, please open a new bug report. glusterfs-3.7.9 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] https://www.gluster.org/pipermail/gluster-users/2016-March/025922.html [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |