Bug 1312333
| Summary: | python-flask-principal: Provide a Python 3 subpackage | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tomas Orsava <torsava> | ||||||
| Component: | python-flask-principal | Assignee: | Richard Marko <rmarko> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 25 | CC: | athoscribeiro, dkrejci, lbalhar, rmarko | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | python-flask-principal-0.4.0-10.fc24 python-flask-principal-0.4.0-10.fc23 python-flask-principal-0.4.0-10.fc25 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2016-11-07 23:23:31 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1285816, 1333770 | ||||||||
| Attachments: |
|
||||||||
|
Description
Tomas Orsava
2016-02-26 12:59:00 UTC
Hello Richard, Do you need any help adding Python 3 support to the RPM? If you need more instructions, a [guide] for porting Python-based RPMs is available. [guide] http://python-rpm-porting.readthedocs.org/ This bug appears to have been reported against 'rawhide' during the Fedora 25 development cycle. Changing version to '25'. Created attachment 1184342 [details] Patch adding python 2 and 3 subpackages Hello, I prepared a patch adding python 2 and 3 subpackages. Here is a COPR build: https://copr.fedorainfracloud.org/coprs/ribeiro/fedora/build/422859/ If you see any problem with the patch, let me know and I will work on it, thanks. Hello Athos.
Your patch looks very good, thank you. I have only a few suggestions:
- You can define a global macro for source name and then use %{srcname} instead 'flask-principal' in the whole specfile.
- Please, move LICENSE file from %doc to %license.
- Global macro for summary is not necessary. You can fill summary into standard Summary: and then use %{summary} macro in subpackages.
Thank you one more time for your effort.
Created attachment 1189463 [details] Patch adding python 2 and 3 subpackages (In reply to Lumír Balhar from comment #4) > Hello Athos. > Hello, > Your patch looks very good, thank you. I have only a few suggestions: > > - You can define a global macro for source name and then use %{srcname} > instead 'flask-principal' in the whole specfile. > - Please, move LICENSE file from %doc to %license. > - Global macro for summary is not necessary. You can fill summary into > standard Summary: and then use %{summary} macro in subpackages. > > Thank you one more time for your effort. I applied the suggested changes, here is an updated patch. COPR build: https://copr.fedorainfracloud.org/coprs/ribeiro/fedora/build/440028/ Hello. Specfile looks good to me now. If maintainer has nothing against we can push it after a week. Thank you. python-flask-principal-0.4.0-10.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3fc31e713c python-flask-principal-0.4.0-10.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-c1537194c1 python-flask-principal-0.4.0-10.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-9132744ddc Thank you all! python-flask-principal-0.4.0-10.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-9132744ddc python-flask-principal-0.4.0-10.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-3fc31e713c python-flask-principal-0.4.0-10.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-c1537194c1 python-flask-principal-0.4.0-10.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. python-flask-principal-0.4.0-10.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. python-flask-principal-0.4.0-10.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. |