Bug 1312407
| Summary: | Review Request: python-pybtex - BibTeX-compatible bibliography processor written in Python | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jerry James <loganjerry> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-03-05 15:59:35 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1312409 | ||
|
Description
Jerry James
2016-02-26 16:05:11 UTC
"Pybtex is Unicode-aware." — thank you. I'd love not to have to fight with bibtex anymore.
The same as with the other package: I don't think you need to preserve timestamps of files that have been modified.
Would it be possible to build both versions from the same build directory?
Would it be possible to replace the bundled jquery with the system one? Same for js-underscore?
You can use the following trick to simplify the %files section:
%files -n python2-{%srcname}
...
%if 0{?with_py3}
...
%endif
%{_bindir}/pybtex*
%{_mandir}/man1/pybtex*
This way the last two lines will fall into python2- subpackage if there's no python3- subpackage.
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > Would it be possible to build both versions from the same build directory? OK, I see that 2to3 is used, so the answer is most likely no. > Would it be possible to replace the bundled jquery with the system one? Same > for js-underscore? I see that it is used in documentation only. I withdraw this question. (In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > "Pybtex is Unicode-aware." — thank you. I'd love not to have to fight with > bibtex anymore. :-) > The same as with the other package: I don't think you need to preserve > timestamps of files that have been modified. Okay, done. > You can use the following trick to simplify the %files section: Nice trick, thanks. I have applied it. I also fixed the nosetests invocations. New URLs: Spec URL: https://jjames.fedorapeople.org/python-pybtex/python-pybtex.spec SRPM URL: https://jjames.fedorapeople.org/python-pybtex/python-pybtex-0.19-2.fc25.src.rpm fedora-review says: - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1638400 bytes in 94 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation and I have to agree. No need to have the same stuff twice, so a -doc subpackage shared between both python versions would be nice. + license file is present, %license is used + license is acceptable (MIT) + latest version + %check is present, checks pass + provides/requires look OK + no scriptlets present or necessary + rpmlint: only false positive spelling errors + executables prefer python3 Package is APPROVED. Please split out -doc. Okay, I will split out -doc. Thank you! New package requested. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-pybtex |