| Summary: | Review Request: python-pyopengl - Python bindings for OpenGL | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jonathan Underwood <jonathan.underwood> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fdc, ngompa13, package-review, projects.rg, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-02-29 14:35:28 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 1249421 | ||
|
Description
Jonathan Underwood
2016-02-27 14:16:39 UTC
Under the python2-* subpackages, your Provides should be set to be equal to %{version}-%{release}, as you are providing the equivalent package under a different name.
For example, the Obsoletes+Provides pair for python2-PyOpenGL should be:
Obsoletes: PyOpenGL < 3.1.0-7
Provides: PyOpenGL = %{version}-%{release}
Same goes for the python2-PyOpenGL-Tk package.
Spec URL: https://fedorapeople.org/~jgu/python-PyOpenGL.spec SRPM URL: https://fedorapeople.org/~jgu/python-PyOpenGL-3.1.1a1-1.fc23.src.rpm * Sat Feb 27 2016 Jonathan Underwood <Jonathan G. Underwood> - 3.1.1a1-1 - Fix Provides for renamed sub-packages - Use standard build and install python packaging macros The guidelines changed a while ago, and package names should be lowercase [https://fedoraproject.org/wiki/Packaging:NamingGuidelines#General_Naming]. Looks good otherwise. rpmlint: only no-documentation, and bogus spelling errors. Why not use the name python-opengl, so subpackages python3-opengl and python2-opengl? Spec URL: https://fedorapeople.org/~jgu/python-pyopengl.spec SRPM URL: https://fedorapeople.org/~jgu/python-pyopengl-3.1.1a1-1.fc23.src.rpm * Sat Feb 27 2016 Jonathan Underwood <Jonathan G. Underwood> - 3.1.1a1-2 - Rename package to python-pyopengl - Rename -Tk subpackages to -tk - Fix Requires of python2-pyopengl-Tk to require python2-pyopengl (In reply to Raphael Groner from comment #4) > Why not use the name python-opengl, so subpackages python3-opengl and > python2-opengl? Well... because the name of the project is pyopengl/PyOpenGl. And in the future, there might well be another project calling itself python-opengl (the pyopengl bindings are only one way this could be done, and have some limitations -in fact there are other bindings that people are working on). Spec URL: https://fedorapeople.org/~jgu/python-pyopengl.spec SRPM URL: https://fedorapeople.org/~jgu/python-pyopengl-3.1.1a1-3.fc23.src.rpm * Sat Feb 27 2016 Jonathan Underwood <Jonathan G. Underwood> - 3.1.1a1-3 - Fix python_provide macro calls for the -tk packages Looks good. I tested the upgrade path in rawhide, no issues. Package is APPROVED. Great, thanks for the review, much appreciated. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-pyopengl |