Bug 1312721
| Summary: | tar complains: <fileName>: file changed as we read it | |||
|---|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Sakshi <sabansal> | |
| Component: | distribute | Assignee: | Sakshi <sabansal> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | ||
| Severity: | medium | Docs Contact: | ||
| Priority: | medium | |||
| Version: | 3.7.9 | CC: | bkunal, bugs, nbalacha, ndevos, olim, pkarampu, rgowdapp, sabansal, smohan, spalai, storage-qa-internal | |
| Target Milestone: | --- | Keywords: | Reopened | |
| Target Release: | --- | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | glusterfs-3.7.12 | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | 1302948 | |||
| : | 1314508 (view as bug list) | Environment: | ||
| Last Closed: | 2016-06-28 12:13:22 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | 1302948, 1335285 | |||
| Bug Blocks: | 1314508 | |||
|
Description
Sakshi
2016-02-29 03:49:25 UTC
REVIEW: http://review.gluster.org/13536 (dht: mkdir must unwind with latest ctime) posted (#1) for review on release-3.7 by Sakshi Bansal COMMIT: http://review.gluster.org/13536 committed in release-3.7 by Raghavendra G (rgowdapp) ------ commit 080af56a02aeec20899ecbc7202a8d293378c1f9 Author: Sakshi Bansal <sabansal> Date: Thu Feb 4 16:02:59 2016 +0530 dht: mkdir must unwind with latest ctime Currently fops like mkdir used the the ctime it gets after creating the directory entry. But setting layout also updates the ctime of a directory. Hence DHT must get the ctime after the setxattr call and unwind with the latest ctime to avoid mismatch in time seen by applications like tar. Backport of http://review.gluster.org/#/c/13352/ > Change-Id: Iecbbe3aac5244af5da9788b48ccf299ca56b4bae > BUG: 1302948 > Signed-off-by: Sakshi Bansal <sabansal> > Reviewed-on: http://review.gluster.org/13352 > Smoke: Gluster Build System <jenkins.com> > CentOS-regression: Gluster Build System <jenkins.com> > NetBSD-regression: NetBSD Build System <jenkins.org> > Reviewed-by: Raghavendra G <rgowdapp> BUG: 1312721 Change-Id: Ie09342d3705b40ce98b2935f05ad4402f74ba069 Signed-off-by: Sakshi Bansal <sabansal> Reviewed-on: http://review.gluster.org/13536 Smoke: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.com> Reviewed-by: Raghavendra G <rgowdapp> Bug 1302948 is still in POST, this change for release-3.7 can not be in MODIFIED yet, not all backports are available. REVIEW: http://review.gluster.org/13830 (dht: update attr information in refresh layout to avoid stale timestamp) posted (#1) for review on release-3.7 by Sakshi Bansal REVIEW: http://review.gluster.org/13831 (dht: report constant directory size) posted (#1) for review on release-3.7 by Sakshi Bansal COMMIT: http://review.gluster.org/13830 committed in release-3.7 by Raghavendra G (rgowdapp) ------ commit 76645128ed54d2cb43cc6a047c0bcc3ee43e9aa8 Author: Sakshi Bansal <sabansal> Date: Sat Mar 19 10:15:24 2016 +0530 dht: update attr information in refresh layout to avoid stale timestamp Consider the scenario where an mkdir has just created the directory but has not healed it yet. A parallel lookup on this entry will find anomalies and trigger a selfheal which will sample the ctime of the directory after the mkdir phase. Meanwhile the mkdir has completed setting the layout and updated the ctime. The selfheal then sees the layout to be healed and returns with the ctime it got after the mkdir phase which has now become stale. However if the lookup happens to unwind before the mkdir then the inode associated with lookup will get linked in the inode table which has the stale ctime. To avoid this selfheal must do an iatt_merge in refresh layout to get the latest timestamp irrespective of whether it needs to heal the layout or not. Backport of http://review.gluster.org/#/c/13781/ > Change-Id: I3634c3978bcc1710705f44b48f3876601682d33e > BUG: 1302948 > Signed-off-by: Sakshi Bansal <sabansal> > Reviewed-on: http://review.gluster.org/13781 > Smoke: Gluster Build System <jenkins.com> > Reviewed-by: Raghavendra G <rgowdapp> > NetBSD-regression: NetBSD Build System <jenkins.org> > CentOS-regression: Gluster Build System <jenkins.com> Change-Id: I3634c3978bcc1710705f44b48f3876601682d33e BUG: 1312721 Signed-off-by: Sakshi Bansal <sabansal> Reviewed-on: http://review.gluster.org/13830 Smoke: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.com> Reviewed-by: Raghavendra G <rgowdapp> COMMIT: http://review.gluster.org/13831 committed in release-3.7 by Raghavendra G (rgowdapp) ------ commit cd32751867252219bd66fa300418579080eef924 Author: Jeff Darcy <jdarcy> Date: Thu Mar 17 13:33:34 2016 -0400 dht: report constant directory size Directory size is meaningless. Every filesystem has its own unpredictable way of increasing or decreasing it, based on internal data structures and even transient conditions. Some filesystems (e.g. ext4) never decrease it at all. Others (e.g. btrfs) don't even report it. Very few programs look at it, and those that do are broken. Unfortunately, one such program is GNU tar, which will complain when it sees different values because at different times we got the value from different DHT subvolumes. To avoid such problems, just report a constant value. Backport of http://review.gluster.org/#/c/13770/ > Change-Id: Id64ce917c75b5f7ff50cb55b6e997f3b3556e7e3 > BUG: 1302948 > Original-author: Shyam <srangana> > Signed-off-by: Jeff Darcy <jdarcy> > Signed-off-by: N Balachandran <nbalacha> > Reviewed-on: http://review.gluster.org/13770 > Smoke: Gluster Build System <jenkins.com> > NetBSD-regression: NetBSD Build System <jenkins.org> > CentOS-regression: Gluster Build System <jenkins.com> > Reviewed-by: Shyamsundar Ranganathan <srangana> > Reviewed-by: Vijay Bellur <vbellur> Change-Id: Id64ce917c75b5f7ff50cb55b6e997f3b3556e7e3 BUG: 1312721 Original-author: Shyam <srangana> Signed-off-by: Jeff Darcy <jdarcy> Signed-off-by: N Balachandran <nbalacha> Reviewed-on: http://review.gluster.org/13831 Smoke: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.com> Reviewed-by: Raghavendra G <rgowdapp> REVIEW: http://review.gluster.org/13836 (cluster/afr: Fix read-child selection in entry create fop) posted (#1) for review on release-3.7 by Pranith Kumar Karampuri (pkarampu) COMMIT: http://review.gluster.org/13836 committed in release-3.7 by Pranith Kumar Karampuri (pkarampu) ------ commit b487738c06ed537ab7fac61bd64db395602a6fed Author: Pranith Kumar K <pkarampu> Date: Fri Mar 25 06:04:23 2016 +0530 cluster/afr: Fix read-child selection in entry create fop When an entry is being created the inode is yet to be linked so args must be filled with gfid and ia_type for it to give consistent iatt. Also handle Dht sending fops on inode not yet linked. >BUG: 1302948 >Change-Id: I6969cacb437cad02f66716f3bf8ec004ffe7c691 >Signed-off-by: Pranith Kumar K <pkarampu> >Reviewed-on: http://review.gluster.org/13827 >Reviewed-by: Krutika Dhananjay <kdhananj> >Smoke: Gluster Build System <jenkins.com> >Reviewed-by: Anuradha Talur <atalur> >NetBSD-regression: NetBSD Build System <jenkins.org> >CentOS-regression: Gluster Build System <jenkins.com> >(cherry picked from commit 2d0c2a9e15a581950a966841866f1f18a8888440) Change-Id: I4be73580368b17af71486693682af66d97d6f70d BUG: 1312721 Signed-off-by: Pranith Kumar K <pkarampu> Reviewed-on: http://review.gluster.org/13836 Smoke: Gluster Build System <jenkins.com> CentOS-regression: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: Krutika Dhananjay <kdhananj> REVIEW: http://review.gluster.org/13844 (debug/trace: Print {acm}times as integers) posted (#1) for review on release-3.7 by Krutika Dhananjay (kdhananj) COMMIT: http://review.gluster.org/13844 committed in release-3.7 by Pranith Kumar Karampuri (pkarampu) ------ commit 324471574dd1f4278b347486187c711b722a9424 Author: Krutika Dhananjay <kdhananj> Date: Thu Mar 24 20:43:05 2016 +0530 debug/trace: Print {acm}times as integers Backport of: http://review.gluster.org/#/c/13826/ This helps in debugging issues with mtime, ctime etc. Change-Id: Ib98a0845d17351dd86ba90c3837b6f4bc78a94a1 BUG: 1312721 Signed-off-by: Krutika Dhananjay <kdhananj> Reviewed-on: http://review.gluster.org/13844 Smoke: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: Niels de Vos <ndevos> CentOS-regression: Gluster Build System <jenkins.com> REVIEW: http://review.gluster.org/13916 (NFS: new option nfs.rdirplus added) posted (#1) for review on release-3.7 by Sakshi Bansal REVIEW: http://review.gluster.org/13916 (NFS: new option nfs.rdirplus added) posted (#2) for review on release-3.7 by Sakshi Bansal REVIEW: http://review.gluster.org/14015 (cluster/afr: Don't let NFS cache stat after writes) posted (#1) for review on release-3.7 by Pranith Kumar Karampuri (pkarampu) COMMIT: http://review.gluster.org/13916 committed in release-3.7 by Kaleb KEITHLEY (kkeithle) ------ commit a47beb0dee2ab40b695fffcc46c650cc8ec34dc1 Author: Sakshi Bansal <sabansal> Date: Thu Mar 31 15:02:03 2016 +0530 NFS: new option nfs.rdirplus added When this option is 'disabled', NFS falls back to standard readdir instead of readdirp Backport of http://review.gluster.org/#/c/13782/ > Change-Id: Icaaf4da6533bee56160d4a81e42bb60f7d341945 > BUG: 1302948 > Signed-off-by: Sakshi Bansal <sabansal> Change-Id: Icaaf4da6533bee56160d4a81e42bb60f7d341945 BUG: 1312721 Signed-off-by: Sakshi Bansal <sabansal> Reviewed-on: http://review.gluster.org/13916 Smoke: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.com> Reviewed-by: Niels de Vos <ndevos> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.10, please open a new bug report. glusterfs-3.7.10 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] https://www.gluster.org/pipermail/gluster-users/2016-April/026164.html [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.9, please open a new bug report. glusterfs-3.7.9 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] https://www.gluster.org/pipermail/gluster-users/2016-March/025922.html [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user REVIEW: http://review.gluster.org/14314 (cluster/afr: Don't let NFS cache stat after writes) posted (#1) for review on release-3.8 by Pranith Kumar Karampuri (pkarampu) Afr change is yet to land in 3.7.x REVIEW: http://review.gluster.org/14454 (cluster/afr: Don't let NFS cache stat after writes) posted (#1) for review on release-3.7 by Pranith Kumar Karampuri (pkarampu) REVIEW: http://review.gluster.org/14454 (cluster/afr: Don't let NFS cache stat after writes) posted (#2) for review on release-3.7 by Pranith Kumar Karampuri (pkarampu) REVIEW: http://review.gluster.org/14454 (cluster/afr: Don't let NFS cache stat after writes.) posted (#3) for review on release-3.7 by Pranith Kumar Karampuri (pkarampu) COMMIT: http://review.gluster.org/14454 committed in release-3.7 by Pranith Kumar Karampuri (pkarampu) ------ commit 0c2fb5d80e248f8b49e0ed13de0165c30429a072 Author: Pranith Kumar K <pkarampu> Date: Sat Mar 19 11:40:26 2016 +0530 cluster/afr: Don't let NFS cache stat after writes. Problem: Afr does post-ops after write but the stat buffer it unwinds is at the time of write, so if nfs client caches this, it will see different ctime when it does stat on it after post-op is done. From NFS client's perspective it thinks the file is changed. Tar which depends on this to be correct keeps giving 'file changed as we read it' warning. If Afr instead has to choose to unwind after post-op, eager-lock, delayed-post-op will have to be disabled which will lead to bad performance for all write usecases. Fix: Don't let client cache stat after write. >Change-Id: Ic6062acc6e5cdd97a9c83c56bd529ec83cee8a23 >BUG: 1302948 >Signed-off-by: Pranith Kumar K <pkarampu> >Signed-off-by: Anuradha Talur <atalur> >Reviewed-on: http://review.gluster.org/13785 >Smoke: Gluster Build System <jenkins.com> >NetBSD-regression: NetBSD Build System <jenkins.org> >CentOS-regression: Gluster Build System <jenkins.com> >Reviewed-by: Niels de Vos <ndevos> BUG: 1312721 Change-Id: I42a5d524bcf2a2034fe48ee8454812ca26a98c37 Signed-off-by: Pranith Kumar K <pkarampu> Reviewed-on: http://review.gluster.org/14454 NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.com> Smoke: Gluster Build System <jenkins.com> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.12, please open a new bug report. glusterfs-3.7.12 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] https://www.gluster.org/pipermail/gluster-devel/2016-June/049918.html [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |