Bug 1312894

Summary: JavaScriptCore headers are in the -devel subpackage, not -jsc-devel
Product: [Fedora] Fedora Reporter: David King <amigadave>
Component: webkitgtk4Assignee: Tomas Popela <tpopela>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: klember, mcatanzaro+wrong-account-do-not-cc, tpopela
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-02-29 14:54:12 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
move javascriptcore headers to the jsc-devel subpackage
none
updated patch to co-own the include dir
none
fix the include directory path none

Description David King 2016-02-29 13:16:22 UTC 
I try to follow https://fedoraproject.org/wiki/Packaging:PkgConfigBuildRequires where possible, and was attempting to do so for a libproxy update that I am working on. Although the jsc-devel subpackage of webkitgtk4 includes the pkg-config file, it does not include the headers, so adding a BuildRequires of "pkgconfig(javascriptcoregtk-4.0)" fails to build as the headers are not present.

The webkitgtk3 package does not have the same subpackage split, so this is not a problem there. The Debian equivalent of the JavaScriptCore -dev package includes both the pkg-config and include files:

https://packages.debian.org/sid/amd64/libjavascriptcoregtk-4.0-dev/filelist
http://koji.fedoraproject.org/koji/rpminfo?rpmID=7434096
Comment 1 David King 2016-02-29 13:18:17 UTC 
Created attachment 1131526 [details]
move javascriptcore headers to the jsc-devel subpackage

Patch to move the headers attached, with a scratch build (currently building): http://koji.fedoraproject.org/koji/taskinfo?taskID=13176645
Comment 2 David King 2016-02-29 13:58:15 UTC 
Created attachment 1131534 [details]
updated patch to co-own the include dir

As per https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function the /usr/includes/webkitgtk-4.0 directory needs to be co-owned by the jsc-devel subpackage. Scratch build with the updated patch: http://koji.fedoraproject.org/koji/taskinfo?taskID=13177244
Comment 3 David King 2016-02-29 14:00:48 UTC 
Created attachment 1131535 [details]
fix the include directory path

Oops, paths must end with a '/'. Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=13177277
Comment 4 Michael Catanzaro 2016-02-29 14:54:12 UTC 
OK, I need to do a new F24 build now so I'll throw this in too, thanks!