Bug 1313517

Summary:	(CVE-2016-2103) Satellite 5: multiple XSS vulnerabilities
Product:	Red Hat Satellite 5	Reporter:	Grant Gainey <ggainey>
Component:	WebUI	Assignee:	Grant Gainey <ggainey>
Status:	CLOSED ERRATA	QA Contact:	Red Hat Satellite QA List <satqe-list>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	570	CC:	dyordano, jhutar, tlestach
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	spacewalk-java-2.3.8-132-sat	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-04-04 15:37:08 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1305681

Description Grant Gainey 2016-03-01 18:25:18 UTC

+++ This bug was initially created as a clone of Bug #1305681 +++

Multiple XSS vulnerabilities have been reported in Satellite 5:

/rhn/systems/PhysicalList.do  list_1680466951_oldfilterval (Parameter)
/rhn/systems/VirtualSystemsList.do  VirtualSystemsList.do (Page)

--- Additional comment from Grant Gainey on 2016-02-15 16:09:25 EST ---

/rhn/systems/PhysicalList.do?list_1680466951_oldfilterval=false">Test<script>alert(1)</script>

List-tag parameters and pagination - I believe we can fix these all at once with code in ListDisplayTag

Kurt - Do we have a specific reproducer for VirtualSystemList? SO far I haven't been able to force a problem.

--- Additional comment from Grant Gainey on 2016-02-16 17:00:42 EST ---

Teaching ListTagHelper.getFilterValue() to htmlEscape results fixes the problem for all places where we use ListTag.

--- Additional comment from Kurt Seifried on 2016-02-20 22:37:17 EST ---

(In reply to Grant Gainey from comment #2)
> /rhn/systems/PhysicalList.
> do?list_1680466951_oldfilterval=false">Test<script>alert(1)</script>
> 
> List-tag parameters and pagination - I believe we can fix these all at once
> with code in ListDisplayTag
> 
> Kurt - Do we have a specific reproducer for VirtualSystemList? SO far I
> haven't been able to force a problem.

I don't have anything more than what I put in this bug unfortunately.

Comment 1 Grant Gainey 2016-03-01 19:36:45 UTC

spacewalk.github 1d6be4c83b925018573ae261dce6b93b9c1868f4

Comment 9 Grant Gainey 2016-03-29 16:44:17 UTC

Interestingly-subtle side-effect of AlphaBar handling

spacewalk.github:
d76cde9c

Comment 14 errata-xmlrpc 2016-04-04 15:37:08 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-0590.html