Bug 1313519

Summary:	relax restraint client xml schema checks
Product:	[Retired] Restraint	Reporter:	Bill Peck <bpeck>
Component:	general	Assignee:	Bill Peck <bpeck>
Status:	CLOSED CURRENTRELEASE	QA Contact:	tools-bugs <tools-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	0.1.23	CC:	beaker-dev-list, bpeck, dcallagh, mjia, rjoost, xdong
Target Milestone:	0.1.24	Keywords:	Reopened, TestBlocker
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-08-05 20:20:50 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Bill Peck 2016-03-01 18:34:53 UTC

Description of problem:
Currently the restraint xml validates the xml to make sure the xml provides proper rpm or fetch elements.  But any extra elements will cause the validation to fail.  This happens if you export an xml from beaker which has extra elements and attributes that restraint doesn't care about.

Version-Release number of selected component (if applicable):
0.2.23-1

Comment 1 Bill Peck 2016-03-01 18:46:54 UTC

*** Bug 1313520 has been marked as a duplicate of this bug. ***

Comment 2 Bill Peck 2016-03-01 18:47:56 UTC

http://gerrit.beaker-project.org/#/c/4705/

Comment 3 Dan Callaghan 2016-04-18 02:02:04 UTC

Looks like this was included with restraint 0.1.24.

Comment 4 Xiyang Dong 2016-07-21 17:52:00 UTC

I am still seeing this issue on restraint-0.1.24-1.el7_2.x86_64:

restraint xml:
https://platform-stg-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/ipa/view/rhel-7.3/view/2.%20Tests/job/ipa-rhel-7.3-candidate-runtest-upstream_automember/1/artifact/beaker-job-rhel-7.3-Server-x86_64.xml

runtest output:
15:32:08 INFO: Restraint command: /usr/bin/restraint -v -v --host 1=qe-blade-14.idmqe.lab.eng.bos.redhat.com:8081 --job=beaker-job-rhel-7.3-Server-x86_64.xml
15:32:09 beaker-job-rhel-7.3-Server-x86_64.xml:5: element repos: Relax-NG validity error : Did not expect element repos there
15:32:09 beaker-job-rhel-7.3-Server-x86_64.xml:5: element repos: Relax-NG validity error : Element recipe has extra content: repos
15:32:09 Document failed validation.

It's blocking us please investigate.

Comment 5 Xiyang Dong 2016-08-05 20:20:50 UTC

(In reply to Xiyang Dong from comment #4)
> I am still seeing this issue on restraint-0.1.24-1.el7_2.x86_64:
> 
> restraint xml:
> https://platform-stg-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/ipa/view/
> rhel-7.3/view/2.%20Tests/job/ipa-rhel-7.3-candidate-runtest-
> upstream_automember/1/artifact/beaker-job-rhel-7.3-Server-x86_64.xml
> 
> runtest output:
> 15:32:08 INFO: Restraint command: /usr/bin/restraint -v -v --host
> 1=qe-blade-14.idmqe.lab.eng.bos.redhat.com:8081
> --job=beaker-job-rhel-7.3-Server-x86_64.xml
> 15:32:09 beaker-job-rhel-7.3-Server-x86_64.xml:5: element repos: Relax-NG
> validity error : Did not expect element repos there
> 15:32:09 beaker-job-rhel-7.3-Server-x86_64.xml:5: element repos: Relax-NG
> validity error : Element recipe has extra content: repos
> 15:32:09 Document failed validation.
> 
> It's blocking us please investigate.

The above issue was actually caused by missing fetch url link of the first task in restraint xml, no validation fail after adding url.
So not a regression.Mark this as closed.