Bug 1314291

Summary: tier: GCC throws Unused variable warning for conf in tier_link_cbk function
Product: [Community] GlusterFS Reporter: Raghavendra Talur <rtalur>
Component: tieringAssignee: Raghavendra Talur <rtalur>
Status: CLOSED CURRENTRELEASE QA Contact: bugs <bugs>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs, prasanna.kalever
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.8rc2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1314548 (view as bug list) Environment:
Last Closed: 2016-06-16 13:59:22 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1314548    

Description Raghavendra Talur 2016-03-03 10:42:47 UTC
Description of problem:
When compiled on F23, we see warning for unused variable.

/home/jenkins/root/workspace/Manually_triggered_regression/xlators/cluster/dht/src/tier-common.c: In function ‘tier_link_cbk’:
10:37:27 /home/jenkins/root/workspace/Manually_triggered_regression/xlators/cluster/dht/src/tier-common.c:33:23: warning: variable ‘conf’ set but not used [-Wunused-but-set-variable]
10:37:27          dht_conf_t   *conf   = NULL;

Comment 1 Vijay Bellur 2016-03-03 10:48:18 UTC
REVIEW: http://review.gluster.org/13591 (tier: Fix unused-but-set-variable warning) posted (#1) for review on master by Raghavendra Talur (rtalur)

Comment 2 Vijay Bellur 2016-03-03 15:35:16 UTC
COMMIT: http://review.gluster.org/13591 committed in master by Jeff Darcy (jdarcy) 
------
commit 6a406b87aa3cd8c086e998fe681197915bd436c2
Author: Raghavendra Talur <rtalur>
Date:   Thu Mar 3 16:09:27 2016 +0530

    tier: Fix unused-but-set-variable warning
    
    Change-Id: Ie5eaf1075b1c9c29dd7d85bf7b61b22e1fbce422
    BUG: 1314291
    Signed-off-by: Raghavendra Talur <rtalur>
    Reviewed-on: http://review.gluster.org/13591
    Reviewed-by: hari gowtham <hari.gowtham005>
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Jeff Darcy <jdarcy>

Comment 3 Prasanna Kumar Kalever 2016-04-05 10:00:33 UTC
*** Bug 1308863 has been marked as a duplicate of this bug. ***

Comment 4 Niels de Vos 2016-06-16 13:59:22 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user