| Summary: | udisks complains too much about disk that was temporarily in my system | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | udo <udovdh> |
| Component: | storaged | Assignee: | Tomas Smetana <tsmetana> |
| Status: | CLOSED UPSTREAM | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | high | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 25 | CC: | mcatanzaro+wrong-account-do-not-cc, phatina, puiterwijk, stefw, tsmetana, udovdh |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-01-04 08:08:51 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
udo
2016-03-03 16:22:38 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 25 development cycle. Changing version to '25'. This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component. udisks is retired. Reassigning to storaged maintainers to assess whether the bug might affect storaged. Could you please run 'udevadm monitor' as root during the disk plugging in and out? It seems the device objects still exist on the bus, hence storaged/udisks2 either missed or didn't receive the udev events of device disconnection. # udevadm monitor monitor will print the received events for: UDEV - the event which udev sends out after rule processing KERNEL - the kernel uevent KERNEL[877455.181889] add /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0 (scsi) KERNEL[877455.181981] add /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0/7:0:0:0 (scsi) KERNEL[877455.182032] add /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0/7:0:0:0/scsi_disk/7:0:0:0 (scsi_disk) KERNEL[877455.182068] add /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0/7:0:0:0/scsi_device/7:0:0:0 (scsi_device) KERNEL[877455.182147] add /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0/7:0:0:0/bsg/7:0:0:0 (bsg) KERNEL[877455.182186] add /devices/virtual/bdi/8:64 (bdi) KERNEL[877455.188251] add /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0/7:0:0:0/block/sde (block) KERNEL[877455.188310] add /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0/7:0:0:0/block/sde/sde1 (block) UDEV [877456.066307] add /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0 (scsi) UDEV [877456.067548] add /devices/virtual/bdi/8:64 (bdi) UDEV [877456.162610] add /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0/7:0:0:0 (scsi) UDEV [877456.163431] add /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0/7:0:0:0/scsi_disk/7:0:0:0 (scsi_disk) UDEV [877456.163797] add /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0/7:0:0:0/scsi_device/7:0:0:0 (scsi_device) UDEV [877456.164270] add /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0/7:0:0:0/bsg/7:0:0:0 (bsg) UDEV [877456.512615] add /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0/7:0:0:0/block/sde (block) UDEV [877456.540981] add /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0/7:0:0:0/block/sde/sde1 (block) KERNEL[877494.394002] add /devices/virtual/bdi/253:13 (bdi) KERNEL[877494.394173] add /devices/virtual/block/dm-13 (block) KERNEL[877494.394215] change /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0/7:0:0:0/block/sde/sde1 (block) UDEV [877494.395288] add /devices/virtual/bdi/253:13 (bdi) UDEV [877494.396379] add /devices/virtual/block/dm-13 (block) KERNEL[877494.396700] change /devices/virtual/block/dm-13 (block) UDEV [877494.451549] change /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0/7:0:0:0/block/sde/sde1 (block) KERNEL[877494.561226] add /module/zlib_deflate (module) UDEV [877494.561715] add /module/zlib_deflate (module) KERNEL[877494.590387] add /module/btrfs (module) UDEV [877494.590781] add /module/btrfs (module) KERNEL[877494.590845] add /devices/virtual/misc/btrfs-control (misc) UDEV [877494.591182] add /devices/virtual/misc/btrfs-control (misc) UDEV [877494.610977] change /devices/virtual/block/dm-13 (block) KERNEL[877499.923434] add /devices/virtual/bdi/btrfs-1 (bdi) UDEV [877499.924521] add /devices/virtual/bdi/btrfs-1 (bdi) KERNEL[877885.896767] remove /devices/virtual/bdi/btrfs-1 (bdi) UDEV [877885.911117] remove /devices/virtual/bdi/btrfs-1 (bdi) KERNEL[877891.622418] remove /devices/virtual/block/dm-13 (block) KERNEL[877891.622779] remove /devices/virtual/block/dm-13 (block) KERNEL[877891.632254] remove /devices/virtual/bdi/253:13 (bdi) UDEV [877891.633598] remove /devices/virtual/block/dm-13 (block) UDEV [877891.633654] remove /devices/virtual/bdi/253:13 (bdi) UDEV [877891.635053] remove /devices/virtual/block/dm-13 (block) KERNEL[877918.220362] change /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0/7:0:0:0/block/sde (block) KERNEL[877918.220451] remove /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0/7:0:0:0/bsg/7:0:0:0 (bsg) KERNEL[877918.220497] remove /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0/7:0:0:0/scsi_device/7:0:0:0 (scsi_device) KERNEL[877918.220539] remove /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0/7:0:0:0/scsi_disk/7:0:0:0 (scsi_disk) KERNEL[877918.220632] remove /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0/7:0:0:0/block/sde/sde1 (block) KERNEL[877918.220756] remove /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0/7:0:0:0/block/sde (block) KERNEL[877918.220833] remove /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0/7:0:0:0 (scsi) UDEV [877918.224634] remove /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0/7:0:0:0/scsi_device/7:0:0:0 (scsi_device) UDEV [877918.224755] remove /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0/7:0:0:0/bsg/7:0:0:0 (bsg) UDEV [877918.224818] remove /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0/7:0:0:0/scsi_disk/7:0:0:0 (scsi_disk) KERNEL[877918.236232] remove /devices/virtual/bdi/8:64 (bdi) KERNEL[877918.236286] remove /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0 (scsi) UDEV [877918.236591] remove /devices/virtual/bdi/8:64 (bdi) UDEV [877918.282459] change /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0/7:0:0:0/block/sde (block) UDEV [877918.285347] remove /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0/7:0:0:0/block/sde/sde1 (block) UDEV [877918.288114] remove /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0/7:0:0:0/block/sde (block) UDEV [877918.288162] remove /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0/7:0:0:0 (scsi) UDEV [877918.288190] remove /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0 (scsi) This is the output of me inserting the disk, openign the LUKS volume, mounting the data, backing up, unmounting and closing the LUKS. Final command before ejecting the disk manually was hdparm -Y /dev/sde. (In reply to udo from comment #5) Hi, I have finally tried this on my home machine and the problem seems to be this: > UDEV [877918.282459] change > /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0/7:0:0:0/block/sde > (block) ... > UDEV [877918.288114] remove > /devices/pci0000:00/0000:00:11.0/ata8/host7/target7:0:0/7:0:0:0/block/sde > (block) The SATA drive removal results in sequence of two uevents: "change" and "remove". Oddly, the first one results in a new drive object being created. At the moment of the event the disk itself is no longer connected and so the new drive object gets a default object path ("/org/freedesktop/UDisks2/drives/drive", since there's no Vendor, Model or Serial) and this is the object that gets removed in the subsequent "remove" action. The original drive object stays on and that causes the errors during housekeeping. I would think that blindly adding new objects on "change" event is a bug. However udisks2 might do that on purpose for some other types of devices. I will try to create some patch for this. UPSTREAM? How can I see a fix? What is the fix? Does it work? Does it work on my system? When will the fix reach me in a normal rpm? None of this is answered and the `customer` is thus not satisfied. |