| Summary: | qemu crash on ppc64 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Than Ngo <than> |
| Component: | gperftools | Assignee: | Tom "spot" Callaway <tcallawa> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 24 | CC: | amit.shah, arjun.is, berrange, cfergeau, codonell, dan, dj, dwmw2, fweimer, itamar, jakub, law, mfabian, pbonzini, pfrankli, rjones, siddhesh, tcallawa, virt-maint |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | ppc64 | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-03-08 14:20:10 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | 1312462 | ||
| Bug Blocks: | |||
|
Description
Than Ngo
2016-03-03 17:42:00 UTC
Same issue as bug 1312462. The tcmalloc ifunc needs to be rewritten or removed. I'm investigating this right now to provide some guidance to gperftools on the issue. See: https://bugzilla.redhat.com/show_bug.cgi?id=1312462#c27 Moving to gperftools. I think we should disable usage of tcmalloc in qemu for ppc64/ppc64le (same as it is disabled for s390(x)) until gperftools are fixed and updated. Or even keep tcmalloc enabled only for x86/x86_64. Will cycle the component to get the qemu people into CC. While the bug only affects ppc64, ppc64le and armv7, gperftools is using an undefined feature and so this could affect any architecture in future. There are two possible workarounds: (1) Disable C++ dynamic sized delete support in gperftools. See: https://bugzilla.redhat.com/show_bug.cgi?id=1312462#c7 (2) Disabling `-z now', which I did already: http://pkgs.fedoraproject.org/cgit/rpms/gperftools.git/commit/?id=c1b9c95df2ccff32d30da7e5a3a02da4eff713b2 does appear to work around the problem on armv7. Does it fix it on ppc64/ppc64le? i'm trying the workarounds and will post the feedbacks today i can confirm that the workaround (2) does fix the crash on ppc64 i also disabled hardened in gperftools, built in f24/rawhide. http://koji.fedoraproject.org/koji/buildinfo?buildID=741708 (In reply to Ngo Than from comment #7) > i also disabled hardened in gperftools, built in f24/rawhide. > http://koji.fedoraproject.org/koji/buildinfo?buildID=741708 I recommend against disabling hardening. Of all things qemu and its dependent libraries like tcmalloc should absolutely be hardened. We should be moving forward with more secure virtualized systems not less secure. I agree with Carlos here. It was fine when we didn't understand the problem and that was the only available workaround, but I think a better workaround (assuming we don't get a proper fix from upstream) is to disable the C++ dynamic sized delete feature. (In reply to Richard W.M. Jones from comment #9) > I agree with Carlos here. It was fine when we didn't understand > the problem and that was the only available workaround, but I > think a better workaround (assuming we don't get a proper fix > from upstream) is to disable the C++ dynamic sized delete feature. Alternatively, don't use IFUNC, and use a pointer dispatch at runtime, taking the extra cost while keeping the feature. I also think packaging guidelines apply here, we want hardening enabled for gperftools, particularly if qemu is going to continue to use tcmalloc: https://fedoraproject.org/wiki/Packaging:Guidelines#PIE I'm going to mark this as a duplicate of the original issue. *** This bug has been marked as a duplicate of bug 1312462 *** |