Bug 1314548

Summary:	tier: GCC throws Unused variable warning for conf in tier_link_cbk function
Product:	[Community] GlusterFS	Reporter:	Raghavendra Talur <rtalur>
Component:	tiering	Assignee:	Raghavendra Talur <rtalur>
Status:	CLOSED CURRENTRELEASE	QA Contact:	bugs <bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.8	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.9	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1314291	Environment:
Last Closed:	2016-04-19 07:22:11 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:	1314291
Bug Blocks:

Description Raghavendra Talur 2016-03-03 21:28:26 UTC

+++ This bug was initially created as a clone of Bug #1314291 +++

Description of problem:
When compiled on F23, we see warning for unused variable.

/home/jenkins/root/workspace/Manually_triggered_regression/xlators/cluster/dht/src/tier-common.c: In function ‘tier_link_cbk’:
10:37:27 /home/jenkins/root/workspace/Manually_triggered_regression/xlators/cluster/dht/src/tier-common.c:33:23: warning: variable ‘conf’ set but not used [-Wunused-but-set-variable]
10:37:27          dht_conf_t   *conf   = NULL;

--- Additional comment from Vijay Bellur on 2016-03-03 16:18:18 IST ---

REVIEW: http://review.gluster.org/13591 (tier: Fix unused-but-set-variable warning) posted (#1) for review on master by Raghavendra Talur (rtalur)

--- Additional comment from Vijay Bellur on 2016-03-03 21:05:16 IST ---

COMMIT: http://review.gluster.org/13591 committed in master by Jeff Darcy (jdarcy) 
------
commit 6a406b87aa3cd8c086e998fe681197915bd436c2
Author: Raghavendra Talur <rtalur>
Date:   Thu Mar 3 16:09:27 2016 +0530

    tier: Fix unused-but-set-variable warning
    
    Change-Id: Ie5eaf1075b1c9c29dd7d85bf7b61b22e1fbce422
    BUG: 1314291
    Signed-off-by: Raghavendra Talur <rtalur>
    Reviewed-on: http://review.gluster.org/13591
    Reviewed-by: hari gowtham <hari.gowtham005>
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Jeff Darcy <jdarcy>

Comment 1 Vijay Bellur 2016-03-03 21:30:12 UTC

REVIEW: http://review.gluster.org/13598 (tier: Fix unused-but-set-variable warning) posted (#1) for review on release-3.7 by Raghavendra Talur (rtalur)

Comment 2 Vijay Bellur 2016-03-04 03:44:45 UTC

COMMIT: http://review.gluster.org/13598 committed in release-3.7 by Pranith Kumar Karampuri (pkarampu) 
------
commit e42c9a9787da89f48b199b4efd05d0d784d2d393
Author: Raghavendra Talur <rtalur>
Date:   Thu Mar 3 16:09:27 2016 +0530

    tier: Fix unused-but-set-variable warning
    
            Backport of http://review.gluster.org/13591
    
    Change-Id: I20c205849f511acf4797a8a53ea59bfaad60bd35
    BUG: 1314548
    Signed-off-by: Raghavendra Talur <rtalur>
    Reviewed-on: http://review.gluster.org/13598
    Smoke: Gluster Build System <jenkins.com>
    CentOS-regression: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 3 Kaushal 2016-04-19 07:22:11 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.9, please open a new bug report.

glusterfs-3.7.9 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-users/2016-March/025922.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user