Bug 1314717

Summary: Init script should include configuration from /etc/sysconfig/monit
Product: [Fedora] Fedora EPEL Reporter: Abel Martín <abel.martin.ruiz>
Component: monitAssignee: Stewart Adam <s.adam>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: el6CC: michel, s.adam
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-11-30 15:06:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Abel Martín 2016-03-04 10:31:55 UTC
Description of problem:

The startup init script for monit relies on local defined variables: rundir, pidfile, user, group and prog.

Monit is run by root by default. If someone wants to change the user and group used to run monit, the init script must be modified.

A better approach would be reading the contents from /etc/sysconfig/monit if this file exists after the definition of those variables, allowing the user to override their default values.

Version-Release number of selected component (if applicable):
5.14

How reproducible:
Reinstalling or updating the package will smash init script file, since it's not a configuration file.

Steps to Reproduce:
1. Change monit init script and adjust its files and directories permissions in order to successfully run it as a non-root user. Configure sudo as needed to allow monit to restart monitored services when needed.
2. Reinstall monit.
3. Open /etc/init.d/monit

Actual results:
User-made changes to the init script are lost, so changes to user and group running monit are not preserved.

Expected results:
It would be desirable if sysadmins could preserve some changes made to the behavior of the init script.

Additional info:
Please, consider modifying monit init script to include the following code after the definition of the aforementioned variables.

if [ -f /etc/sysconfig/monit ]; then
    . /etc/sysconfig/monit
fi

Comment 1 Ben Cotton 2020-11-05 16:51:08 UTC
This message is a reminder that EPEL 6 is nearing its end of life. Fedora will stop maintaining and issuing updates for EPEL 6 on 2020-11-30. It is our policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a 'version' of 'el6'.

Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later EPEL version.

Thank you for reporting this issue and we are sorry that we were not able to fix it before EPEL 6 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged  change the 'version' to a later Fedora version prior this bug is closed as described in the policy above.

Comment 2 Ben Cotton 2020-11-05 16:53:51 UTC
This message is a reminder that EPEL 6 is nearing its end of life. Fedora will stop maintaining and issuing updates for EPEL 6 on 2020-11-30. It is policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a 'version' of 'el6'.

Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later EPEL version.

Thank you for reporting this issue and we are sorry that we were not able to fix it before EPEL 6 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version, you are encouraged to change the 'version' to a later version prior this bug is closed as described in the policy above.

Comment 3 Ben Cotton 2020-11-30 15:06:32 UTC
EPEL el6 changed to end-of-life (EOL) status on 2020-11-30. EPEL el6 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
EPEL please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.