Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Red Hat Satellite engineering is moving the tracking of its product development work on Satellite to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "Satellite project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs will be migrated starting at the end of May. If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "Satellite project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/SAT-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1314775

Summary:	hammer activation-key --unlimited-content-hosts flag is confusing
Product:	Red Hat Satellite	Reporter:	Roman Plevka <rplevka>
Component:	Hammer	Assignee:	Zach Huntington-Meath <zhunting>
Status:	CLOSED ERRATA	QA Contact:	Katello QA List <katello-qa-list>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	6.2.0	CC:	bbuckingham, cwelton, kbidarka
Target Milestone:	Unspecified	Keywords:	Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
URL:	http://projects.theforeman.org/issues/14333
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-07-27 11:30:14 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Roman Plevka 2016-03-04 12:59:39 UTC

Description of problem:
unlimited-hosts flag is not required by `hammer activation-key create` as there's no limit set by default if no --max-content-hosts is used.

the `hammer activation-key update` on the other hand uses `--unlimited-content-hosts` flag for changing the limit to `unlimited`. However, this flag requires a boolean value (true/false, yes/no, 1/0). So we can have an AK with unlimited content hosts and update it using `--unlimited-content-hosts true`. The other way around - setting it back to limited, requires `--max-content-hosts` no matter what:

```
# hammer -u admin -p changeme activation-key update --unlimited-content-hosts false --id 78 --organization-id 3

Could not update the activation key:
Validation failed: Max content hosts cannot be nil
```

making the use of `hammer activation-key update --unlimited-content-hosts false` useless as the same effect is being done using `--max-content-hosts` option only.

I believe we can drop `--unlimited-content-hosts` option from `create` subcommand
and change the behaviour of the same option in `update` subcommand not to accept any bool valie (only check for falg presence).

Version-Release number of selected component (if applicable):
6.2.0

How reproducible:
always

Steps to Reproduce:
1. hammer activation-key create --unlimited-content-hosts --organization-id 1 --name foo
2. hammer activation-key create --organization-id 1 --name bar
3. compare the content host limit of both activation keys

# for the `update` subcommand:
4. create AK with no content host limit
5. hammer activation key update --organization-id 1 --id 70 --unlimited-content-hosts false

Actual results:
as described above

Expected results:
no `--unlimited-content-host` option `create` subcommand,
make the same flag in `update` subcommand not to require any boolean value (presence-based check only)

Additional info:
snap 2.1

Comment 4 Zach Huntington-Meath 2016-03-23 18:02:15 UTC

Created redmine issue http://projects.theforeman.org/issues/14333 from this bug

Comment 5 Bryan Kearney 2016-04-22 16:08:32 UTC

Moving to POST since upstream bug http://projects.theforeman.org/issues/14333 has been closed
-------------
Zach Huntington-Meath
Applied in changeset commit:hammer-cli-katello|fb494a72c1f4206004490cdfde11d36709aa9267.

Comment 6 Roman Plevka 2016-05-30 13:17:12 UTC

VERIFIED
Sat6.2.0 Beta (GA13.1)

The option now acts like a flag and makes more sense:

<pre>
# hammer -u admin -p changeme activation-key create --unlimited-hosts --organization-id 1 --name foo
Activation key created
# hammer activation-key create --organization-id 1 --name bar
[Foreman] Password for admin: 
Activation key created
# hammer activation-key list --organization-id 1
[Foreman] Password for admin: 
---|---------|----------------|-----------------------|-------------
ID | NAME    | HOST LIMIT     | LIFECYCLE ENVIRONMENT | CONTENT VIEW
---|---------|----------------|-----------------------|-------------
12 | foo     | 0 of Unlimited |                       |             
13 | bar     | 0 of Unlimited |                       |             
---|---------|----------------|-----------------------|-------------

# hammer activation-key update --organization-id 1 --id 12 --help
Usage:
    hammer activation-key update [OPTIONS]

Options:
...
 --max-hosts MAX_HOSTS                               maximum number of registered content hosts
...
 --unlimited-hosts                                   set hosts max to unlimited
 -h, --help                                          print help

# hammer -u admin -p changeme activation-key update --organization-id 1 --id 12 --max-hosts 1
Activation key updated
# hammer -u admin -p changeme activation-key list --organization-id 1
---|---------|----------------|-----------------------|-------------
ID | NAME    | HOST LIMIT     | LIFECYCLE ENVIRONMENT | CONTENT VIEW
---|---------|----------------|-----------------------|-------------
12 | foo     | 0 of 1         |                       |             
13 | bar     | 0 of Unlimited |                       |             
---|---------|----------------|-----------------------|-------------

# hammer activation-key update --organization-id 1 --id 12 --unlimited-hosts
[Foreman] Password for admin: 
Activation key updated
hammer -u admin -p changeme activation-key list --organization-id 1---|---------|----------------|-----------------------|-------------
ID | NAME    | HOST LIMIT     | LIFECYCLE ENVIRONMENT | CONTENT VIEW
---|---------|----------------|-----------------------|-------------
12 | foo     | 0 of Unlimited |                       |             
13 | bar     | 0 of Unlimited |                       |             
---|---------|----------------|-----------------------|-------------



</pre>

Comment 7 Bryan Kearney 2016-07-27 11:30:14 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1501