Bug 1314917

Summary:	Cannot unset Git/SCM
Product:	[Community] Copr	Reporter:	Daniel Vrátil <me>
Component:	frontend	Assignee:	Jakub Kadlčík <jkadlcik>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	jkadlcik
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-03-29 12:18:54 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Daniel Vrátil 2016-03-04 21:12:08 UTC

Description of problem:

It's not possible to completely unset Git/Tito and Mock SCMs, Copr will always complain about URL being mandatory. That makes sense if other fields are filled, but if I completely unset all the fields and hit "Save", I'd expect Copr to completely disable the Git integration.


How reproducible:
always


Steps to Reproduce:
1. Set Git/Tito Git URL on any package, save it
2. Edit the package again
3. Unset the Git URL and all other fields
4. Click "Save"

Actual results:
You get warning about Git URL being a mandatory field

Expected results:
The URL as well as all other fields are stored

Additional info:

Comment 1 Jakub Kadlčík 2016-03-08 12:33:40 UTC

Hello Daniel, thank you for the feedback.

Blame me for that, I forgot the reset button.

Modified in: ae3ef9b

Comment 2 Jakub Kadlčík 2016-03-15 08:51:27 UTC

Code with this fix is currently deployed on testing server.
You can test it before it will be deployed to production.
Please see: http://copr-fe-dev.cloud.fedoraproject.org

Comment 3 Jakub Kadlčík 2016-03-29 12:18:54 UTC

Copr production machines were upgraded to version containing a fix to this issue.
If you are not satisfied with provided solution, please feel free to reopen this.