Bug 1314933

Summary: ipmitool kontronoem nextboot results in segmentation fault
Product: Red Hat Enterprise Linux 6 Reporter: Rachel Sibley <rasibley>
Component: ipmitoolAssignee: Boris Ranto <branto>
Status: CLOSED ERRATA QA Contact: Rachel Sibley <rasibley>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 6.8CC: tlavigne
Target Milestone: rcKeywords: Regression
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: ipmitool-1.8.15-2.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1315737 (view as bug list) Environment:
Last Closed: 2016-05-10 20:08:27 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1315737    

Description Rachel Sibley 2016-03-04 23:43:03 UTC
Description of problem:
Segmentation fault occurs if ipmitool kontronoem nextboot is executed without a supported device option.  If not supported, ipmitool should print a message stating it's not supported and device is not present. 

Version-Release number of selected component (if applicable):
~]# cat /etc/redhat-release
Red Hat Enterprise Linux Server release 6.8 Beta (Santiago)

~]# uname -r
2.6.32-621.el6.x86_64

~]# rpm -q ipmitool
ipmitool-1.8.15-1.el6.x86_64


How reproducible:
Always

Steps to Reproduce:
1. ipmitool kontronoem nextboot
2.
3.

Actual results:
Not enough parameters given.
nextboot <device>
Supported devices:
- BIOS
- FDD
- HDD
- CDROM
- network
Segmentation fault (core dumped)


Expected results:
No segmentation Fault, usage message stating it's not supported

Additional info:
Occurs on multiple systems running ipmitool-1.8.15-1.el6.x86_64 (RHEL 6.8 2.6.32-621.el6.x86_64).  Can not reproduce on ipmitool-1.8.13-8.el7_1.x86_64 (RHEL 7.2 3.10.0-326.el7.x86_64)

Comment 2 Boris Ranto 2016-03-08 12:27:12 UTC
I think I can see where the problem lies. It was introduced by a code cleanup in lib/ipmi_kontronoem.c that went into 1.8.15 and it is actually a regression. I'll send a patch upstream. In the mean-time could you re-test with the following build to see if it fixed your problem:

https://brewweb.devel.redhat.com/taskinfo?taskID=10619443

Comment 4 Boris Ranto 2016-03-08 13:44:13 UTC
The patch for this is already upstream, we need to back-port 12eeca602c104980cd36d89fa5b25ebd56b3c574 to fix this.

Comment 5 Rachel Sibley 2016-03-08 15:22:30 UTC
Looks like this is resolved using your build, no longer seeing segmentation fault and usage message is displayed.

Before
================================
# rpm -q ipmitool
ipmitool-1.8.15-1.el6.x86_64

# cat /etc/redhat-release
Red Hat Enterprise Linux Server release 6.8 Beta (Santiago)

#  ipmitool kontronoem nextboot
Not enough parameters given.
nextboot <device>
Supported devices:
- BIOS
- FDD
- HDD
- CDROM
- network
Segmentation fault (core dumped)

After
==============================
# yum install http://download.devel.redhat.com/brewroot/work/tasks/9447/10619447/ipmitool-1.8.15-2.el6.x86_64.rpm

# rpm -q ipmitool
ipmitool-1.8.15-2.el6.x86_64

# ipmitool kontronoem nextboot
Not enough parameters given.
nextboot <device>
Supported devices:
- BIOS
- FDD
- HDD
- CDROM
- network
Nextboot set failed

Comment 8 Rachel Sibley 2016-03-18 13:37:04 UTC
ALL TESTS PASSED

Verified as fixed in the ipmitool-1.8.15-2.el6.x86_64, no longer seeing a segmentation fault when running 'ipmitool kontronoem nextboot' without an option

~]# cat /etc/redhat-release
Red Hat Enterprise Linux Server release 6.8 Beta (Santiago)

~]# uname -r
2.6.32-627.el6.x86_64

~]# rpm -q ipmitool
ipmitool-1.8.15-2.el6.x86_64

~]#  ipmitool kontronoem nextboot
Not enough parameters given.
nextboot <device>
Supported devices:
- BIOS
- FDD
- HDD
- CDROM
- network
~]#

Comment 10 errata-xmlrpc 2016-05-10 20:08:27 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHEA-2016-0771.html