Bug 1315805

Summary:	Review Request: python-requests-unixsocket - Use requests to talk HTTP via a UNIX domain socket
Product:	[Fedora] Fedora	Reporter:	Haïkel Guémar <karlthered>
Component:	Package Review	Assignee:	Chandan Kumar <chkumar246>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	chkumar246, chkumar, dradez, ngompa13, package-review, pasik
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-04-02 15:51:42 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1290163, 1315809, 1411746

Description Haïkel Guémar 2016-03-08 16:15:15 UTC

Spec URL: https://hguemar.fedorapeople.org/reviews/python-requests-unixsocket.spec
SRPM URL: https://hguemar.fedorapeople.org/reviews/python-requests-unixsocket-0.1.5-1.fc23.src.rpm
Description: Use requests to talk HTTP via a UNIX domain socket
Fedora Account System Username: hguemar

Comment 1 Neal Gompa 2016-11-06 21:25:05 UTC

@Chandan:

Do you plan on reviewing this anytime soon?

Comment 2 Neal Gompa 2016-11-06 21:34:02 UTC

Here's a few comments about the package:

* Since this module does not output any scripts, the comment in the %install section is meaningless.

* We now prefer that scripts be Python 3 powered rather than Python 2 powered, so %py3_install should be after %py2_install, not before. (Not that this matters in the context of this package.)

* Python 3 subpackage doesn't have LICENSE under %license. That should be fixed.

Comment 3 Dan Radez 2019-04-02 14:59:57 UTC

Not sure what the right way to revive this review request is.
I've uploaded new files addressing the comments.
https://radez.fedorapeople.org/python-requests-unixsocket.spec
https://radez.fedorapeople.org/python-requests-unixsocket-0.1.5-2.fc30.src.rpm

I'll ping Haïkel too.

Comment 4 Haïkel Guémar 2019-04-02 15:45:32 UTC

No worries, I'm fine with Dan taking over this review :)

Comment 5 Dan Radez 2019-04-02 15:51:42 UTC

Closing this duplicate of a new bug to continue the review.

*** This bug has been marked as a duplicate of bug 1695172 ***

Comment 6 Red Hat Bugzilla 2023-09-14 03:19:07 UTC

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days