Bug 1315939

Summary:	'gluster volume get' returns 0 value for server-quorum-ratio
Product:	[Community] GlusterFS	Reporter:	Atin Mukherjee <amukherj>
Component:	glusterd	Assignee:	Atin Mukherjee <amukherj>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	3.7.8	CC:	amukherj, bsrirama, bugs, ggarg, sasundar
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.7.9	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1300596	Environment:
Last Closed:	2016-04-19 07:20:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1300231, 1300596
Bug Blocks:

Description Atin Mukherjee 2016-03-09 04:09:17 UTC

+++ This bug was initially created as a clone of Bug #1300596 +++

+++ This bug was initially created as a clone of Bug #1300231 +++

Description of problem:
-----------------------
Even after setting server quorum ratio, volume get returns the value as 0

Version-Release number of selected component (if applicable):
-------------------------------------------------------------
mainline

How reproducible:
-----------------
Always

Steps to Reproduce:
-------------------
1. Enable server-quorum on the volume
2. Set the server-quorum-ratio to any value , say 80%
3. Get the server-quorum-ration using 'gluster volume get'

Actual results:
---------------
'gluster volume get' returns server-quorum-ratio as 0

Expected results:
-----------------
'gluster volume get' should return the correct value for server-quorum-ratio

Additional info:
----------------

[root@ ~]# gluster volume set all server-quorum-ratio 100%
volume set: success

[root@ ~]# gluster volume get rvolume server-quorum-ratio
Option                                  Value                                   
------                                  -----                                   
cluster.server-quorum-ratio             0                                       

[root@dhcp37-152 ~]# gluster volume get rvolume all | grep server-quorum-ratio
cluster.server-quorum-ratio             0

[root@ ~]# gluster volume info rvolume | grep server-quorum-ratio
cluster.server-quorum-ratio: 100%

--- Additional comment from Byreddy on 2016-01-20 05:44:28 EST ---

Add to above info.

always (with or without change), the get is returning zero for cluster.server-quorum ratio.

--- Additional comment from Vijay Bellur on 2016-01-21 04:19:53 EST ---

REVIEW: http://review.gluster.org/13272 (glusterd: volume get should pick options from priv->opts too) posted (#1) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Vijay Bellur on 2016-03-04 03:53:16 EST ---

REVIEW: http://review.gluster.org/13272 (glusterd: volume get should pick options from priv->opts too) posted (#2) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Vijay Bellur on 2016-03-06 23:45:54 EST ---

REVIEW: http://review.gluster.org/13272 (glusterd: volume get should pick options from priv->opts too) posted (#3) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Vijay Bellur on 2016-03-08 08:58:31 EST ---

COMMIT: http://review.gluster.org/13272 committed in master by Jeff Darcy (jdarcy) 
------
commit 05d3d95afa62ef3271f0fe3c7272e1e19638c448
Author: Atin Mukherjee <amukherj>
Date:   Thu Jan 21 14:48:34 2016 +0530

    glusterd: volume get should pick options from priv->opts too
    
    As of now volume get was not looking for all the global options maintained in
    option dictionary in glusterd_conf_t. This patch includes the same.
    
    Change-Id: Ib05259a2dcacc4a712cae4217fe4a6553b61da56
    BUG: 1300596
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: http://review.gluster.org/13272
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Gaurav Kumar Garg <ggarg>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Jeff Darcy <jdarcy>

Comment 1 Vijay Bellur 2016-03-09 04:10:49 UTC

REVIEW: http://review.gluster.org/13651 (glusterd: volume get should pick options from priv->opts too) posted (#1) for review on release-3.7 by Atin Mukherjee (amukherj)

Comment 2 Vijay Bellur 2016-03-09 07:25:59 UTC

COMMIT: http://review.gluster.org/13651 committed in release-3.7 by Atin Mukherjee (amukherj) 
------
commit 3122e47e70494fd224f764f86fae29eca16ac06b
Author: Atin Mukherjee <amukherj>
Date:   Thu Jan 21 14:48:34 2016 +0530

    glusterd: volume get should pick options from priv->opts too
    
    Backport of http://review.gluster.org/13272
    
    As of now volume get was not looking for all the global options maintained in
    option dictionary in glusterd_conf_t. This patch includes the same.
    
    Change-Id: Ib05259a2dcacc4a712cae4217fe4a6553b61da56
    BUG: 1315939
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: http://review.gluster.org/13272
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Gaurav Kumar Garg <ggarg>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Jeff Darcy <jdarcy>
    Reviewed-on: http://review.gluster.org/13651

Comment 3 Kaushal 2016-04-19 07:20:46 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.9, please open a new bug report.

glusterfs-3.7.9 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-users/2016-March/025922.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user