Bug 1315949

Summary: If you choose Automatic Placement for Azure Instance, it complains that required fields are missing.
Product: Red Hat CloudForms Management Engine Reporter: Jeff Teehan <jteehan>
Component: ProvisioningAssignee: William Fitzgerald <wfitzger>
Status: CLOSED ERRATA QA Contact: Jeff Teehan <jteehan>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.6.0CC: gblomqui, jhardy, jprause, kmorey, nstephan, obarenbo, ssainkar
Target Milestone: GA   
Target Release: 5.6.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: provisioning:ui
Fixed In Version: 5.6.0.0 Doc Type: Bug Fix
Doc Text:
Previously, provisioning for Azure Best fit did not select automatically for environment fields. As a result, you needed to manually select environment fields for Azure Best fit. This fix modified yaml file, created best fit Azure method, added field azure to the Placement class and configured best fit Azure method for Azure. Best fit for Azure will now select automatically for environment fields.
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-06-29 15:40:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: Azure Target Upstream Version:
Embargoed:

Description Jeff Teehan 2016-03-09 05:40:41 UTC
Description of problem:
For provisioning of an Azure VM, if you choose Automatic Placement under the Environment Tab and click Submit, it complains that required fields have not been selected.  Problem is, you can't select those fields if you choose automatic placement.

Personally, I'd get rid of Automatic Placement for 5.6 as I can see endless scenarios where it won't be able to work.

Version-Release number of selected component (if applicable):
cfme-hyperv-5.6.0.0-nightly-20160308112121-1.x86_64.vhd

How reproducible:
Always

Steps to Reproduce:
1.  Provision an Azure VM and fill out everything except Environment.
2.  At the Environment Tab, click the Placement:  Choose Automatically checkbox.
3.  Click Submit

Actual results:
Flash message appears saying you must select a Virtual Private Cloud.

Expected results:
It should pick automatically.  Again, I really don't think it can.

Additional info:

Comment 3 CFME Bot 2016-03-11 15:40:50 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/9295db066f6294fcf3c6b549971c3f54982d3e10

commit 9295db066f6294fcf3c6b549971c3f54982d3e10
Author:     william fitzgerald <wfitzger>
AuthorDate: Wed Mar 9 20:15:25 2016 -0500
Commit:     william fitzgerald <wfitzger>
CommitDate: Thu Mar 10 11:38:58 2016 -0500

    Automate - Added automatic placement for Azure
    
    Added field azure to the Placement class
    
    Added best_fit_azure method.
    
    Modified yaml file for auto placement.
    
    Create spec for testing
    
    Modified security_groups to  singular in mixing method.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1315949

 .../VM/Provisioning/Placement.class/__class__.yaml | 20 +++++++++++
 .../Placement.class/__methods__/best_fit_azure.rb  | 37 ++++++++++++++++++++
 .../__methods__/best_fit_azure.yaml                | 12 +++++++
 .../VM/Provisioning/Placement.class/default.yaml   |  2 ++
 .../miq_provision_azure_dialogs_template.yaml      |  2 ++
 .../method_validation/azure_auto_placement_spec.rb | 40 ++++++++++++++++++++++
 6 files changed, 113 insertions(+)
 create mode 100644 db/fixtures/ae_datastore/ManageIQ/Cloud/VM/Provisioning/Placement.class/__methods__/best_fit_azure.rb
 create mode 100644 db/fixtures/ae_datastore/ManageIQ/Cloud/VM/Provisioning/Placement.class/__methods__/best_fit_azure.yaml
 create mode 100644 spec/automation/unit/method_validation/azure_auto_placement_spec.rb

Comment 4 Jeff Teehan 2016-04-28 16:34:38 UTC
Well, the specific error is gone, but this still isn't working.  Getting error [NoMethodError]: undefined method `ems_ref' for nil:NilClass and no VM.  Probably because the automatic placement idea is a bad one, that and the way we do the Security groups is also wrong.

We can either close this and open a new one down the line or reopen this and get it running end to end.

I'm going to kick this back for now with the understanding you may place it in ON_QA again, in which case I'll open a new issue.

Ideas?

Comment 5 William Fitzgerald 2016-06-14 22:03:44 UTC
Jeff,

Since this is a different issue, can you please open a new ticket?

Thanks,

Bill

Comment 6 Jeff Teehan 2016-06-14 23:13:20 UTC
Hmm, last I checked it was working.  Let me process the ON_QA and then if I still see the error, I open a new bug.  Thanks.

Comment 7 Jeff Teehan 2016-06-15 19:10:38 UTC
This has been working for several builds now, including today's RC2.2.  I'm moving it to verified.  I think it was fixed with the Security Group fix.   Used https://10.16.7.187/miq_request/show/615r1

Comment 9 errata-xmlrpc 2016-06-29 15:40:57 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1348

Comment 10 Jeff Teehan 2016-10-03 16:11:31 UTC
Added Polarion test case