Bug 1315964

Description of problem:
unable to upgrade 5.6.0@RHEL6@externalOracle to 5.7.0@RHEL6@externalPostgreSQL (IMO would be same for all PostgreSQL variants)


Version-Release number of selected component (if applicable):
Satellite-5.7.0-RHEL6-re20150108.2-x86_64.iso
rhn-upgrade-5.7.0.29-1.el6sat.noarch


How reproducible:
always


Steps to Reproduce:
1. Attempt to upgrade 5.6.0@RHEL6@externalOracle to
   5.7.0@RHEL6@externalPostgreSQL (no OS upgrade)


Actual results:
# /mnt/tmp/install.pl --upgrade --external-postgresql --run-updater=yes
* Starting Red Hat Satellite installer.
* Performing pre-install checks.
* Pre-install checks complete.  Beginning installation.
* RHN Registration.
** Registration: System is already registered with RHN.  Not re-registering.
* Upgrade flag passed.  Stopping necessary services.
* Purging conflicting packages.
* Checking for uninstalled prerequisites.
There are some packages from Red Hat Enterprise Linux that are not part
of the @base group that Satellite will require to be installed on this
system. The installer will try resolve the dependencies automatically.
* Installing RHN packages.
Warning: yum did not install the following packages:
        OpenIPMI
        OpenIPMI-libs
        lm_sensors-libs
        net-snmp-libs
        uuid
* Now running spacewalk-setup.
* Setting up SELinux..
** Database: Setting up database connection for PostgreSQL backend.
Hostname (leave empty for local)? extpg.example.com
Port [5432]? 
Database? mydb3
Username? mydbuser
Password? 
** Database: Populating database.
The Database has schema.  Would you like to clear the database [Y]? y
** Database: Clearing database.
** Database: Shutting down spacewalk services that may be using DB.
** Database: Services stopped.  Clearing DB.
** Database: Re-populating database.
*** Progress: ####################################
* Setting up users and groups.
** GPG: Initializing GPG and importing key.
You must enter an email address.
Admin Email Address? root@localhost
* Performing initial configuration.
* Activating Red Hat Satellite.
** Certificate not activated.
** Upgrade process requires the certificate to be activated after the schema is upgraded.
* Enabling Monitoring.
* Configuring apache SSL virtual host.
Should setup configure apache's default ssl server for you (saves original ssl.conf) [Y]? y
* Configuring tomcat.
* Configuring jabberd.
* Creating SSL certificates.
** Skipping SSL certificate generation.
* Deploying configuration files.
* Update configuration in database.
* Setting up Cobbler..
cobblerd does not appear to be running/accessible
Cobbler requires tftp and xinetd services be turned on for PXE provisioning functionality. Enable these services [Y]? y
This portion of the Red Hat Satellite upgrade process has successfully completed.
Please refer to appropriate upgrade document in /etc/sysconfig/rhn/satellite-upgrade
for any remaining steps in the process.


Expected results:
DB should be migrated.


Additional info:
In /usr/share/perl5/vendor_perl/Spacewalk/Setup.pm (spacewalk-setup-2.3.0-15.el6sat.noarch) there is:


[...]
use constant ORACLE_RHNCONF_BACKUP =>
  '/tmp/oracle-rhn.conf';
[...]
sub is_db_migration {
        [...]
        if (-f ORACLE_RHNCONF_BACKUP) {
                read_config(ORACLE_RHNCONF_BACKUP, \%config);
        } else {
                read_config(DEFAULT_RHN_CONF_LOCATION, \%config);
        }

        # Satellite 5.3 and older used default_db -> we know we are on Oracle
        # -> we know we want to migrate to PostgreSQL (no --external-oracle specified)
        return 1 if (exists $config{'default_db'});

        # Satellite 5.4 and beyond used db_backend
        return 1 if (exists $config{'db_backend'} and $config{'db_backend'} eq 'oracle');

        return 0;
}
[...]


So if there is no file /tmp/oracle-rhn.conf (with backup of rhn.conf created before configuration to new external PostgreSQL was written), we are not doing the migration.

That file seems to be created in install.pl:


[...]
sub backup_oracle_rhnconf {
  my $opts = shift;
  my $schema_version;

  return if ((not $opts->{'upgrade'}) or -f Spacewalk::Setup::ORACLE_RHNCONF_BACKUP);

  foreach my $schema ('satellite-schema', 'rhn-satellite-schema') {
    system("rpm -q --qf='%{VERSION}' $schema >/dev/nul 2>&1");
    if ($? >> 8 == 0) {
      $schema_version = `rpm -q --qf='%{VERSION}' $schema 2>/dev/null`;
    }
  }

  if ($schema_version and $schema_version =~ /^5\.[2345]\./ and
      -f Spacewalk::Setup::DEFAULT_RHN_CONF_LOCATION) {
    system("cp", "-f", Spacewalk::Setup::DEFAULT_RHN_CONF_LOCATION, Spacewalk::Setup::ORACLE_RHNCONF_BACKUP);
  }
}
[...]


So if I read that correctly, that file is created only when satellite-schema package is installed in version 5.5 and below.