Bug 1315994

Summary:	force iso image filename lowercase
Product:	[oVirt] ovirt-engine	Reporter:	Stefano Cislaghi <cislo78>
Component:	BLL.Storage	Assignee:	Tal Nisan <tnisan>
Status:	CLOSED WONTFIX	QA Contact:	Elad <ebenahar>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	3.6.0	CC:	bugs, cislo78, ebenahar, lveyde, sbonazzo, tnisan, ylavi
Target Milestone:	---	Flags:	sbonazzo: ovirt-4.3-
Target Release:	---
Hardware:	All
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-05-30 09:05:02 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1091377

Description Stefano Cislaghi 2016-03-09 08:29:11 UTC

Description of problem:
When uploading an iso to iso domain the filename is always accepted even if the extension is uppercase.
ISOs with uppercase extension are not recognized and not used.

Version-Release number of selected component (if applicable):
verified on 3.6

How reproducible:
just upload an iso with uppercase extension.

Steps to Reproduce:
1.
2.
3.

Actual results:
iso is simply not recognized and by consequence not used.

Expected results:


Additional info:
Not verified on previous versions.

Comment 1 Tal Nisan 2016-03-09 09:12:21 UTC

Isn't it better to just be able to use ISO prefix case insensitive? This sounds like a more reasonable solution to the problem

Comment 2 Stefano Cislaghi 2016-03-09 09:24:31 UTC

Hi Tal,
I was just wondering why uppercase prefix is not recognized, but i'm no developer so i assume there's some good reason for this to work this way, that i'm not aware of.
If it isn't, of course it should be more comfortable the way you suggest.

Comment 3 Tal Nisan 2016-03-09 09:43:58 UTC

I think this solution will be the better one in that case.
Amit, when you are looking at this bug please try to reach that solution

Comment 4 Sandro Bonazzola 2016-03-09 11:58:59 UTC

tal, do you mind move also the product to ovirt-engine if you plan to solve this bug there?

Comment 5 Tal Nisan 2016-03-09 12:42:07 UTC

Assuming the solution will be trivial of course, if there is a legacy reason for not checking extensions in case insensitive due to some limitation and it won't be possible we will have to resort to the first proposed solution

Comment 6 Lev Veyde 2016-03-28 16:21:05 UTC

I think that the bug needs to be renamed force ISO filename *extension* to be lowercase, if any, as there is no reason to touch the filename itself.

IMHO the best option would be to simply modify the filter to accept any combination of ISO extension.

Comment 7 Yaniv Lavi 2017-02-07 15:34:32 UTC

We plan to address this in next release by moving ISOs to use from API\UI.
We will address this then.

Comment 8 Daniel Erez 2017-11-28 09:57:10 UTC

@Tal - has this issue been already handled as part of your work on upload ISO?

Comment 9 Allon Mureinik 2017-11-28 13:41:11 UTC

(In reply to Daniel Erez from comment #8)
> @Tal - has this issue been already handled as part of your work on upload
> ISO?

4.2.z will allow you to upload an arbitrary file to a DATA domain and use it as an ISO.
Once we make sure this that feature is in, this BZ can probably be closed as WONTFIX.

Comment 10 Tal Nisan 2018-05-30 09:05:02 UTC

Since 4.2 we support uploading ISO images to a data domain, the image itself is recognized as an ISO regardless of the name or prefix thus making this bug obsolete