Bug 1316024
Summary: | Allow clearing of statistics region's aux_data field | ||||||
---|---|---|---|---|---|---|---|
Product: | Red Hat Enterprise Linux 7 | Reporter: | Bryn M. Reeves <bmr> | ||||
Component: | kernel | Assignee: | Bryn M. Reeves <bmr> | ||||
kernel sub component: | Core | QA Contact: | Storage QE <storage-qe> | ||||
Status: | CLOSED NOTABUG | Docs Contact: | |||||
Severity: | medium | ||||||
Priority: | high | CC: | agk, msnitzer | ||||
Version: | 7.2 | ||||||
Target Milestone: | rc | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2016-03-17 17:03:29 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Bryn M. Reeves
2016-03-09 09:42:58 UTC
I've no objections to @stats_clear_aux Created attachment 1134589 [details]
dm-stats: add @stats_clear_aux message
Untested patch to add a @stats_clear_aux message. This was chosen over modifying the @stats_set_aux message to avoid the need to add optional arguments (as @stats_create uses for the precise_timestamps and histogram extensions).
While working on the patch for this I realised that the current dm-stats code in the kernel actually now assigns a default hard-coded aux_data (and program_id) of "-" - I'd mistakenly thought that these values were added only during output if these fields had a NULL pointer in the dm_stats structure. Re-setting the field to "-" using @stats_set_aux does work (although it looks a bit weird) so this change is not necessary for the current groups support. Closing NOTABUG. Is this documented? If not, then Documentation/device-mapper/statistics.txt may need a patch. |