Bug 1316051
| Summary: | upgrade should abort at pre checking steps | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Anping Li <anli> |
| Component: | Cluster Version Operator | Assignee: | Scott Dodson <sdodson> |
| Status: | CLOSED WONTFIX | QA Contact: | Anping Li <anli> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | 3.2.0 | CC: | aos-bugs, jokerman, mmccomas |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-08-25 15:51:37 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Description of problem: By mistake I run upgrate playbook against fresh hosts. It should abort at "Verify upgrade can proceed" rather than play some upgrade tasks. Version-Release number of selected component (if applicable): atomic-openshift-utils-3.0.54 How reproducible: always Steps to Reproduce: 1. parepare the rhel7 fresh hosts 2. ansible-playbook -i config/hostmini /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_1_to_v3_2/upgrade.yml Actual results: root@dhcp-129-213 upmin]# ansible-playbook -i config/hostmini /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_1_to_v3_2/upgrade.yml PLAY [Populate config host groups] ******************************************** TASK: [fail ] ***************************************************************** skipping: [localhost] <----snip----> PLAY [Evaluate additional groups for upgrade] ********************************* GATHERING FACTS *************************************************************** ok: [localhost] TASK: [Evaluate etcd_hosts_to_backup] ***************************************** ok: [localhost] => (item=minimaster.example.com) PLAY [Verify upgrade can proceed] ********************************************* TASK: [fail ] ***************************************************************** skipping: [minimaster.example.com] TASK: [fail ] ***************************************************************** skipping: [minimaster.example.com] TASK: [fail ] ***************************************************************** skipping: [minimaster.example.com] PLAY [Verify upgrade can proceed] ********************************************* GATHERING FACTS *************************************************************** ok: [mininode.example.com] ok: [minimaster.example.com] TASK: [os_firewall | Install firewalld packages] ****************************** skipping: [minimaster.example.com] skipping: [mininode.example.com] <---snip----> <---snip----> TASK: [Abort if insufficient disk space for etcd backup] ********************** skipping: [minimaster.example.com] TASK: [Install etcd (for etcdctl)] ******************************************** changed: [minimaster.example.com] TASK: [Generate etcd backup] ************************************************** fatal: [minimaster.example.com] => One or more undefined variables: 'dict object' has no attribute 'etcd_data_dir' FATAL: all hosts have already failed -- aborting PLAY RECAP ******************************************************************** to retry, use: --limit @/root/upgrade.retry localhost : ok=10 changed=0 unreachable=0 failed=0 minimaster.example.com : ok=63 changed=15 unreachable=1 failed=0 mininode.example.com : ok=52 changed=12 unreachable=0 failed=0 Expected results: Additional info: