Bug 1316221

Summary: EAP modules for org.hibernate.search.infinispan-storage are useing the same module slot (jdg-6.4) and might overwritten if different JDG versions are installed
Product: [JBoss] JBoss Data Grid 6 Reporter: wfink
Component: EAP modulesAssignee: Tristan Tarrant <ttarrant>
Status: ASSIGNED --- QA Contact: Martin Gencur <mgencur>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 6.5.0, 6.6.0, 6.5.1CC: mgencur, sanne.grinovero
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description wfink 2016-03-09 17:17:11 UTC 
Description of problem:
The module org.hibernate.search.infinispan-storage use the slot "jdg-6.4" for the JDG 6.5||6.6 releases.
All other modules are using the correct slot for the release.

This might override the module from former releases!


See content of download:
https://access.redhat.com/jbossnetwork/restricted/softwareDetail.html?softwareId=42331&product=data.grid&version=&downloadType=distributions
Comment 2 Sanne Grinovero 2016-03-09 23:10:46 UTC 
This module is used (as in consumed) exclusively by modules distributed within JBoss EAP.
The modules in JDG 6.x aim at delivering this additional feature to EAP version *6.4*.

I'm sorry for the confusion but the intention for the module slot was to mark the target EAP version it is delivering the feature *to*, not the identification of which JDG version did build it.

Indeed there is a problem with overwrites: we did not expect people to want to run both JDG 6.4 and 6.5 in the same EAP server. We could improve on that with an alias so that people can easily switch the default, but it makes sense the file the be unique as there can be only one default.

When it comes to support both EAP6.x and EAP7.x the modules will need to be implemented differently, so they could be "jdg-6.4" and "jdg-7.0" and we could ship both of them.
Comment 3 wfink 2016-03-14 10:31:16 UTC 
There is a need to pack the module different, maybe separate from the other EAP-modules provided for JDG.
The module name should be set to reflect both (eap and jdg) version if this is important and necessary to not override
Comment 4 Sanne Grinovero 2016-03-14 23:22:56 UTC 
The module name can not change with each JDG versions, as EAP needs to look for a module with a specific id.
Comment 5 wfink 2016-03-21 12:04:55 UTC 
The module for hibernate-seach need to be shipped as a separate one which can be installed "on demand" with the needed version.
Comment 6 Vaclav Dedik 2016-04-19 15:12:52 UTC 
Do I understand it correctly that we need this fixed for both JDG 6.5 and JDG 6.6?

Also, if I understand it correctly, this could simply be fixed by repackaging the EAP modules, i.e. unzipping the EAP modules, moving the hibernate search modules out of the directory into a new directory and then zip it back up creating two packages.
Comment 7 wfink 2016-04-19 15:38:49 UTC 
I would not fix JDG 6.5.

For 6.6 and further the idea was to have a separate EAP module for hibernate.
The "jdg-6.4" slot must be the same, but if you separate this module from the rest you can install the EAP-modules without the hibernate stuff for EAP.
And this only if needed.