Bug 1316284

Summary: Review Request: python-htmlmin - HTML Minifier
Product: [Fedora] Fedora Reporter: Julien Enselme <jujens>
Component: Package ReviewAssignee: William Moreno <williamjmorenor>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, williamjmorenor
Target Milestone: ---Flags: williamjmorenor: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-04-05 10:09:32 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Julien Enselme 2016-03-09 21:32:31 UTC
Spec URL: http://dl.jujens.eu/SPECS/python-htmlmin.spec
SRPM URL: http://dl.jujens.eu/SRPMS/python-htmlmin-0.1.10-1.fc23.src.rpm
Description:
A configurable HTML Minifier with safety features.

Fedora Account System Username: jujens

Comment 1 Julien Enselme 2016-03-10 21:28:15 UTC
Just corrected the spec to have the shortcommit in the changelog and release tag:
SRPM: http://dl.jujens.eu/SRPMS/python-htmlmin-0.1.10-1.gitcc611c3.fc23.src.rpm
SPEC: http://dl.jujens.eu/SPECS/python-htmlmin.spec

Comment 2 William Moreno 2016-03-11 21:28:25 UTC
Package Review
==============

Delete the .buildinfo directory after build the documentation with sphinx
python-htmlmin-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-htmlmin-doc/html/.buildinfo
python-htmlmin-doc.noarch: W: file-not-utf8 /usr/share/doc/python-htmlmin-doc/html/objects.inv


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. 
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python2-htmlmin-0.1.10-1.gitcc611c3.fc23.noarch.rpm
          python3-htmlmin-0.1.10-1.gitcc611c3.fc23.noarch.rpm
          python-htmlmin-doc-0.1.10-1.gitcc611c3.fc23.noarch.rpm
          python-htmlmin-0.1.10-1.gitcc611c3.fc23.src.rpm
python-htmlmin-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-htmlmin-doc/html/.buildinfo
python-htmlmin-doc.noarch: W: file-not-utf8 /usr/share/doc/python-htmlmin-doc/html/objects.inv
4 packages and 0 specfiles checked; 0 errors, 2 warnings.

Rpmlint (installed packages)
----------------------------
python-htmlmin-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-htmlmin-doc/html/.buildinfo
python-htmlmin-doc.noarch: W: file-not-utf8 /usr/share/doc/python-htmlmin-doc/html/objects.inv
3 packages and 0 specfiles checked; 0 errors, 2 warnings.

Requires
--------
python3-htmlmin (rpmlib, GLIBC filtered):
    /usr/bin/python3
    python(abi)

python2-htmlmin (rpmlib, GLIBC filtered):
    python(abi)

python-htmlmin-doc (rpmlib, GLIBC filtered):


Provides
--------
python3-htmlmin:
    python3-htmlmin

python2-htmlmin:
    python-htmlmin
    python2-htmlmin

python-htmlmin-doc:
    python-htmlmin-doc

Source checksums
----------------
https://github.com/mankyd/htmlmin/archive/cc611c3c6eabac97aaa4e4e249be6e8910b12abd/htmlmin-cc611c3c6eabac97aaa4e4e249be6e8910b12abd.tar.gz :
  CHECKSUM(SHA256) this package     : 2752e215ddf5dd19187d04e6dcc52802edd3c59a7001d0e6edb6db130abce56a
  CHECKSUM(SHA256) upstream package : 2752e215ddf5dd19187d04e6dcc52802edd3c59a7001d0e6edb6db130abce56a

Comment 3 Julien Enselme 2016-03-12 09:12:06 UTC
* Sat Mar 12 2016 Julien Enselme <jujens> 0.1.10-2.gitcc611c3
- Remove hidden dir in doc package


SPEC: http://dl.jujens.eu/SPECS/python-htmlmin.spec
SRPM: http://dl.jujens.eu/SRPMS/python-htmlmin-0.1.10-2.gitcc611c3.fc23.src.rpm

Comment 4 William Moreno 2016-03-30 17:58:25 UTC
Looks good, aproved.

Comment 5 Julien Enselme 2016-03-30 18:21:49 UTC
Thanks for the review.

Comment 6 Gwyn Ciesla 2016-04-01 01:50:30 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-htmlmin

Comment 7 Fedora Update System 2016-04-01 10:00:20 UTC
python-htmlmin-0.1.10-2.gitcc611c3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-79fd623f64

Comment 8 Fedora Update System 2016-04-01 10:44:24 UTC
python-htmlmin-0.1.10-2.gitcc611c3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8e2abc58b2

Comment 9 Fedora Update System 2016-04-02 05:24:52 UTC
python-htmlmin-0.1.10-2.gitcc611c3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-79fd623f64

Comment 10 Fedora Update System 2016-04-02 05:26:08 UTC
python-htmlmin-0.1.10-2.gitcc611c3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-8e2abc58b2

Comment 11 Fedora Update System 2016-04-05 10:09:29 UTC
python-htmlmin-0.1.10-2.gitcc611c3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2016-04-13 20:23:52 UTC
python-htmlmin-0.1.10-2.gitcc611c3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.