| Summary: | Can't delete puppet module repo | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Satellite | Reporter: | Brad Buckingham <bbuckingham> | ||||
| Component: | Content Management | Assignee: | Andrew Kofink <akofink> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Roman Plevka <rplevka> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 6.0.4 | CC: | cwelton, djschaap, jentrena, mmccune, rplevka, stkachen | ||||
| Target Milestone: | Unspecified | Keywords: | Triaged | ||||
| Target Release: | Unused | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| URL: | http://projects.theforeman.org/issues/14141 | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | rubygem-katello-3.0.0.26-1 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2016-07-27 11:23:14 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Attachments: |
|
||||||
|
Description
Brad Buckingham
2016-03-10 18:33:06 UTC
Created from redmine issue http://projects.theforeman.org/issues/14141 It looks like this issue may have been introduced by the following commit which introduced additional modeling for the module: https://github.com/Katello/katello/commit/eccdbdebb3f859afa83998c44fca20fc441d5505#diff-7c38fb2787634c4edb51230f15b7ecc4R8 It looks like the model does have a 'repositories' relationship, so we can probably update 'puppet_module.repoids' to be something like 'puppet_module.repository_ids'. We need to make sure, however, that there are no other scenarios where repoids is still being used. Full text search on all of Katello, Foreman, and Hammer-Cli modules shows that there are no other instances of the string ".repoids". Moving to POST since upstream bug http://projects.theforeman.org/issues/14141 has been closed ------------- Brad Buckingham It looks like this issue may have been introduced by the following commit which introduced additional modeling for the module: https://github.com/Katello/katello/commit/eccdbdebb3f859afa83998c44fca20fc441d5505#diff-7c38fb2787634c4edb51230f15b7ecc4R8 It looks like the model does have a 'repositories' relationship, so we can probably update 'puppet_module.repoids' to be something like 'puppet_module.repository_ids'. We need to make sure, however, that there are no other scenarios where repoids is still being used. ------------- Andrew Kofink Applied in changeset commit:katello|910a37157f295bb5b11a393c19c417172b365156. I just tested 910a37157f295bb5b11a393c19c417172b365156 on a 6.2 beta and it still fails. Removing all puppet modules from the puppet repo results in the puppet repo being deleted correctly (so I can delete the puppet repo if it's empty and does not contain any modules). (In reply to Julio Entrena Perez from comment #7) > I just tested 910a37157f295bb5b11a393c19c417172b365156 on a 6.2 beta and it > still fails. > Removing all puppet modules from the puppet repo results in the puppet repo > being deleted correctly (so I can delete the puppet repo if it's empty and > does not contain any modules). Testing this on 6.2.0 Beta (GA12.1) - I'm unable to reproduce this issue. I created a puppet repo, uploaded a ntp module, i even tried to publish + promote CV containing this module - every time puppet repository has been successfully deleted. Julio, Could you share your steps for reproducing the issue? (In reply to Roman Plevka from comment #8) > > Julio, Could you share your steps for reproducing the issue? - Create a test product (to be able to create a puppet repo in it) - Create a puppet repo - Upload or sync at least one puppet module - Try to delete tyhe puppet repository undefined method `repoids' for #<Katello::PuppetModule:0x007f0f12168140> Can't comment on GA12.1 since I need to keep public beta to be able to confirm customer reported issues. Created attachment 1160943 [details]
puppet repo removal task
VERIFIED
on sat6.2.0 GA12.1
The task now finishes successfully and the repo is removed even with uploaded puppet modules. I also tried to publish and promote a content view with the module, removal still works flawlessly.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2016:1501 |