Bug 1317212

Summary: please re-enable ReplayGain plugin
Product: [Fedora] Fedora Reporter: smitna
Component: beetsAssignee: Michele Baldessari <michele>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: 24CC: michele
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: beets-1.3.17-4.fc24 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-03-26 18:08:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
patch to spec file none

Description smitna 2016-03-13 00:23:35 UTC 
Created attachment 1135758 [details]
patch to spec file

Description of problem:
Plugin "replaygain" is actually generated upon build but removed upon install.  A comment in the spec file provides a rationale:

# **** Disabled plugins ****
# due to missing dependencies or dependencies being in rpmfusion
...
# replaygain --> mp3gain (rpmfusion only)

However, mp3gain is not a strict dependency of this plugin but merely a particular backend option.  A functional GStreamer 1.0 backend is also supported, and all of its dependencies are available in official Fedora repositories, so there is no need to disable this plugin.


Version-Release number of selected component (if applicable):
1.3.17-1.fc24
(see:  http://koji.fedoraproject.org/koji/buildinfo?buildID=734412)

Additional info:
Attached is a patch to the RPM spec file.  It successfully builds SRPM and RPMs (via mock) in Fedora 23, and I have confirmed that the replaygain feature is functional when configured according to official docs:

http://beets.readthedocs.org/en/v1.3.17/plugins/replaygain.html#gstreamer
Comment 1 Fedora Update System 2016-03-14 17:43:13 UTC 
beets-1.3.17-4.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-408bff7815
Comment 2 Fedora Update System 2016-03-15 21:31:24 UTC 
beets-1.3.17-4.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-408bff7815
Comment 3 Fedora Update System 2016-03-26 18:08:30 UTC 
beets-1.3.17-4.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.