Bug 1317385
Summary: | lang.sh and lang.csh should export FC_LANG | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Peng Wu <pwu> | ||||
Component: | setup | Assignee: | Ondrej Vasik <ovasik> | ||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | 28 | CC: | i18n-bugs, jonathan, karsten, kent.neo, lnykryn, ovasik, petersen, pknirsch, pwu, tagoh, zbyszek | ||||
Target Milestone: | --- | Keywords: | i18n, Reopened | ||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2019-05-07 07:55:36 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Peng Wu
2016-03-14 07:45:08 UTC
.i18n file is usually loaded from both scripts of /etc/profile.d/lang.sh and /etc/profile.d/lang.csh and it has to be portable. adding "export key=val" thing into .i18n breaks things on csh. so adding similar thing of the following line in /etc/profile.d/lang.csh may be required for lang.sh as well: if ( -f "$HOME/.i18n" ) then eval `sed -ne 's|^[[:blank:]]*\([^#=]\{1,\}\)=\([^=]*\)|setenv \1 \2;|p' "$HOME/.i18n"` set sourced=1 endif Sorry, I am not familiar with shell scripts. Is the following script portable? FC_LANG=zh-CN export FC_LANG Created attachment 1140797 [details]
proposed patch
tested as the following: % sh -c 'echo "FOO=bar" > ~/.i18n && . initscripts-9.65/lang.sh; sh -c printenv |grep FOO; rm ~/.i18n' FOO=bar % sh -c 'echo "FOO=bar" > ~/.i18n && . initscripts-9.65.orig/lang.sh; sh -c printenv |grep FOO; rm ~/.i18n' % This message is a reminder that Fedora 23 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 23. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '23'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 23 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Fedora 23 changed to end-of-life (EOL) status on 2016-12-20. Fedora 23 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. Should this not be re-opened? Or does it not affect F24+? Is it not better though to modify lang.sh and lang.csh to export FC_LANG? I don't think font-tweak-tool should put "export" in ".i18n". (In reply to Jens Petersen from comment #8) > Is it not better though to modify lang.sh and lang.csh to export FC_LANG? If we want to restrict the env vars to export, that would be an option yes. Is there any documentation for FC_LANG? I assume it is font-config-language, but I cannot find any pertinent docs. Apparently not. but you're right. it is the env var to determine the default language in fontconfig. This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle. Changing version to '28'. This message is a reminder that Fedora 28 is nearing its end of life. On 2019-May-28 Fedora will stop maintaining and issuing updates for Fedora 28. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '28'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 28 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. This seems fixed in f30 (at least). $ sh -c 'echo "FC_LANG=ja" > ~/.i18n && . /etc/profile.d/lang.sh; sh -c printenv |grep FC_LANG; rm ~/.i18n' FC_LANG=ja $ tcsh -c 'echo "FC_LANG=ja" > ~/.i18n && source /etc/profile.d/lang.csh ; tcsh -c printenv | grep FC_LANG; rm ~/.i18n' FC_LANG=ja $ rpm -qf /etc/profile.d/lang.sh setup-2.13.3-1.fc30.noarch $ rpm -qf /etc/profile.d/lang.csh setup-2.13.3-1.fc30.noarch |