Bug 1317390

network-manager-applet-1.2.0-1.rc1.fc24 NetworkManager-libreswan-1.2.0-1.fc24 NetworkManager-fortisslvpn-1.2.0-1.fc24 NetworkManager-openconnect-1.2.0-1.fc24 NetworkManager-pptp-1.2.0-1.fc24 NetworkManager-openvpn-1.2.0-1.fc24 NetworkManager-vpnc-1.2.0-1.fc24 NetworkManager-1.2.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-7e287fa1e6

Created attachment 1149420 [details]
Use a single dbus name for VPN plugin & the pptp helper service

Uh, I think this needs more work. Attaching a patch for review.

NetworkManager-1.2.0-1.fc24, NetworkManager-fortisslvpn-1.2.0-1.fc24, NetworkManager-libreswan-1.2.0-1.fc24, NetworkManager-openconnect-1.2.0-1.fc24, NetworkManager-openvpn-1.2.0-1.fc24, NetworkManager-pptp-1.2.0-1.fc24, NetworkManager-vpnc-1.2.0-1.fc24, network-manager-applet-1.2.0-1.rc1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-7e287fa1e6

(In reply to Lubomir Rintel from comment #2)
> Created attachment 1149420 [details]
> Use a single dbus name for VPN plugin & the pptp helper service
> 
> Uh, I think this needs more work. Attaching a patch for review.


Patch lgtm. The following are minor style issues. Fix them if you agree.




+static gboolean
+handle_need_secrets (NMDBusPptpPpp *object,
+              GDBusMethodInvocation *invocation,
+              gpointer user_data)

whitespace.





»···if (priv->saddr) {
»···»···g_free (priv->saddr);
»···»···priv->saddr = NULL;
»···}

To bad, we don't have nm-glib around, like we do on nm-openvpn. g_clear_pointer() would be nice.




nm_pptp_plugin_new() should not contain any additional logic like creating the dbus-skeleton. I would overwrite init_sync() instead.



+    errno = 0;
+    if (inet_ntop (AF_INET, &naddr, buf, sizeof (buf) - 1) == NULL) {
+         g_set_error (error,
+                      NM_VPN_PLUGIN_ERROR,
+                      NM_VPN_PLUGIN_ERROR_LAUNCH_FAILED,
+                      _("no usable addresses returned for PPTP VPN gateway '%s' (%d)"),
+                      src, errno);
+         return FALSE;
+    }

inet_ntop() doesn't fail due to a regular error.

How i can test this build? Is it available in the testing repo?

NetworkManager-1.2.2-1.fc24 NetworkManager-vpnc-1.2.2-1.fc24 NetworkManager-libreswan-1.2.2-1.fc24 NetworkManager-openconnect-1.2.2-1.fc24 NetworkManager-fortisslvpn-1.2.2-1.fc24 NetworkManager-pptp-1.2.2-1.fc24 NetworkManager-openvpn-1.2.2-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-73f517cf1a

NetworkManager-1.2.2-1.fc24, NetworkManager-fortisslvpn-1.2.2-1.fc24, NetworkManager-libreswan-1.2.2-1.fc24, NetworkManager-openconnect-1.2.2-1.fc24, NetworkManager-openvpn-1.2.2-1.fc24, NetworkManager-pptp-1.2.2-1.fc24, NetworkManager-vpnc-1.2.2-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-73f517cf1a

NetworkManager-1.2.2-1.fc24, NetworkManager-fortisslvpn-1.2.2-1.fc24, NetworkManager-libreswan-1.2.2-1.fc24, NetworkManager-openconnect-1.2.2-1.fc24, NetworkManager-openvpn-1.2.2-1.fc24, NetworkManager-pptp-1.2.2-1.fc24, NetworkManager-vpnc-1.2.2-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

I've installed and tested nm with my company settings. Company network support sys its connected, and i see that both connections in order and connected, no login issue which show up when i enter my pin wrong. Just to test it. I also can confirm that resolv.conf contains proper dns ip addresses, but i have no packet flow. When i see the statistics from the adapter i would tend to say that all traffic goes to the first connected adapter and not the second one. They are have big differences in RX/TX package count. 
I doesn't find a documentation for this feature, so it's possible i forgot something to configure?

Not work for me:

d="0a4517eb-0b61-43c2-b5d1-27536db72d68" name="XXX" pid=8949 uid=1000 result="fail" reason="The 'vpnc' plugin only supports a single active connection."
---

rpm -qa|grep vpn
NetworkManager-openvpn-1.2.2-1.fc24.x86_64
vpnc-script-20140805-4.gitdf5808b.fc24.noarch
NetworkManager-vpnc-1.2.2-1.fc24.x86_64
NetworkManager-openvpn-gnome-1.2.2-1.fc24.x86_64
vpnc-0.5.3-27.svn550.fc24.x86_64
openvpn-2.3.11-1.fc24.x86_64
NetworkManager-vpnc-gnome-1.2.2-1.fc24.x86_64

(In reply to jrh from comment #10)
> Not work for me:
> 
> NetworkManager-vpnc-1.2.2-1.fc24.x86_64

nm-vpn 1.2.x does not support this yet. Was added for 1.4, not backported as of now:

https://git.gnome.org/browse/network-manager-vpnc/commit/?id=cdad999c132e1e9ef611c255ffd4843e3a3d12c4

Sorry, misunderstood the blog update (https://blogs.gnome.org/lkundrak/2016/04/20/networkmanager-1-2-is-here/).
Anyway, seems to work fine:) Thanks a lot!
Hope it will released in version 1.3 if not backported to 1.2.