Bug 1317592

I'll take it for a review.

Thx for the upstream query about the separate license file. Here is one minor nit:

* Test suite
  - If you are going to expand the test suite in %prep section, you should use
    %setup macro together with -a or -b parameter for that [1].
  - Nevertheless, the safer option is to expand the test suite in the %check
    section. This way you will avoid possible pollution of the rebuilt gem and
    the necessity to copy the test suite.
  - You don't really need to delete the test suite after execution, unless you
    insist on using rpmbuild directly (in that case, I can imagine it might
    cause some issues)


Otherwise the package looks sane => APPROVED

I am also going to sponsor you now, so please follow with the next steps [2]. But please consider fixing the issues I pointed out above prior importing the package into Fedora.



[1] http://www.rpm.org/max-rpm/s1-rpm-inside-macros.html
[2] https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner

Thanks, Vit for the review.
I fixed the issued that you pointed out. [1]

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=13353927
I ran Koji again after that.

Do we need to update below page, because I referred the page?
https://fedoraproject.org/wiki/Packaging:Ruby#Test_suites_not_included_in_the_package

And thanks for your sponsor!! and will check next steps[2].


[1]
$ git diff 97f720687b588892ceb9e3d810711589c9468b58 rubygem-websocket-extensions.spec 
diff --git a/rubygem-websocket-extensions.spec b/rubygem-websocket-extensions.spec
index fabfade..f9c419c 100644
--- a/rubygem-websocket-extensions.spec
+++ b/rubygem-websocket-extensions.spec
@@ -40,8 +40,6 @@ gem unpack %{SOURCE0}
 
 gem spec %{SOURCE0} -l --ruby > %{gem_name}.gemspec
 
-tar -xzf %{SOURCE1}
-
 %build
 # Create the gem as gem install only works on a gem file
 gem build %{gem_name}.gemspec
@@ -60,10 +58,10 @@ cp -a .%{gem_dir}/* \
 
 # Run the test suite
 %check
+tar -xzf %{SOURCE1}
 cp -pr spec/ ./%{gem_instdir}
 pushd .%{gem_instdir}
 rspec spec
-rm -rf spec
 popd
 
 %files

(In reply to Jun Aruga from comment #3)
> Do we need to update below page, because I referred the page?
> https://fedoraproject.org/wiki/Packaging:
> Ruby#Test_suites_not_included_in_the_package

Ah, this is where it comes from. Not sure if that is worth of the effort but ...

>  # Run the test suite
>  %check
> +tar -xzf %{SOURCE1}
>  cp -pr spec/ ./%{gem_instdir}
>  pushd .%{gem_instdir}

If you moved the tar after the pushd, you could get rid of the "cp" line as well.

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rubygem-websocket-extensions

Hi, Vit

I updated the spec and srpm file following your review again. [1]
Also finished to run Mock and Koji for test again.

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=13366172

[1]
$ git diff 3e6b5d0cfe833e89748d87df2934732cfe32d92b rubygem-websocket-extensions.spec 
diff --git a/rubygem-websocket-extensions.spec b/rubygem-websocket-extensions.spec
index f9c419c..0a628f9 100644
--- a/rubygem-websocket-extensions.spec
+++ b/rubygem-websocket-extensions.spec
@@ -58,9 +58,8 @@ cp -a .%{gem_dir}/* \
 
 # Run the test suite
 %check
-tar -xzf %{SOURCE1}
-cp -pr spec/ ./%{gem_instdir}
 pushd .%{gem_instdir}
+tar -xzf %{SOURCE1}
 rspec spec
 popd

(In reply to Jun Aruga from comment #6)
Thx. Now just go ahead, import the SRPM into dist-git and build it in Koji.

(In reply to Vít Ondruch from comment #7)
> (In reply to Jun Aruga from comment #6)
> Thx. Now just go ahead, import the SRPM into dist-git and build it in Koji.

Yes, I imported the SRPM by "fedpkg import PATH_TO_SRPM".
Also built it by "fedpkg build" right now. [1]

[1]
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=13366277

(In reply to Jun Aruga from comment #8)

Nice.

Once the build is done, don't forget to close the issue with "Rawhide" resolution and fill in the "Fixed in version" field.