Bug 1317623

Summary: ostree fails to install into installer iso
Product: [Fedora] Fedora Reporter: Dennis Gilmore <dennis>
Component: ostreeAssignee: Colin Walters <walters>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 24CC: acarter, dennis, pfrields, walters
Target Milestone: ---Keywords: Patch
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-03-18 17:54:38 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
patch locations for F24
none
Fixed - patch locations for F24 none

Description Dennis Gilmore 2016-03-14 17:15:01 UTC
Description of problem:
2016-03-14 02:34:30,898: running /spin-kickstarts/atomic-installer/lorax-embed-repo.tmpl
running /spin-kickstarts/atomic-installer/lorax-embed-repo.tmpl
2016-03-14 02:34:31,126: template command error in /spin-kickstarts/atomic-installer/lorax-embed-repo.tmpl:
template command error in /spin-kickstarts/atomic-installer/lorax-embed-repo.tmpl:
2016-03-14 02:34:31,127:   runcmd ostree --repo=/tmp/lorax.valebh9x/iso-graft/content/repo pull --mirror ostree-mirror fedora-atomic/24/x86_64/docker-host
  runcmd ostree --repo=/tmp/lorax.valebh9x/iso-graft/content/repo pull --mirror ostree-mirror fedora-atomic/24/x86_64/docker-host
2016-03-14 02:34:31,129:   subprocess.CalledProcessError: Command '['ostree', '--repo=/tmp/lorax.valebh9x/iso-graft/content/repo', 'pull', '--mirror', 'ostree-mirror', 'fedora-atomic/24/x86_64/docker-host']' returned non-zero exit 
status 1
  subprocess.CalledProcessError: Command '['ostree', '--repo=/tmp/lorax.valebh9x/iso-graft/content/repo', 'pull', '--mirror', 'ostree-mirror', 'fedora-atomic/24/x86_64/docker-host']' returned non-zero exit status 1
Traceback (most recent call last):
  File "/usr/sbin/lorax", line 353, in <module>
    main(sys.argv)
  File "/usr/sbin/lorax", line 209, in main
    remove_temp=True, verify=opts.verify)
  File "/usr/lib/python3.5/site-packages/pylorax/__init__.py", line 355, in run
    treebuilder.build()
  File "/usr/lib/python3.5/site-packages/pylorax/treebuilder.py", line 300, in build
    self._runner.run(tmpl, **self.add_template_vars)
  File "/usr/lib/python3.5/site-packages/pylorax/ltmpl.py", line 219, in run
    self._run(commands)
  File "/usr/lib/python3.5/site-packages/pylorax/ltmpl.py", line 238, in _run
    f(*args)
  File "/usr/lib/python3.5/site-packages/pylorax/ltmpl.py", line 484, in runcmd
    stdout = runcmd_output(cmd)
  File "/usr/lib/python3.5/site-packages/pylorax/executils.py", line 345, in runcmd_output
    return execWithCapture(cmd[0], cmd[1:], **kwargs)
  File "/usr/lib/python3.5/site-packages/pylorax/executils.py", line 247, in execWithCapture
    reset_handlers=reset_handlers, reset_lang=reset_lang)[1]
  File "/usr/lib/python3.5/site-packages/pylorax/executils.py", line 199, in _run_program
    raise subprocess.CalledProcessError(proc.returncode, argv, output)
subprocess.CalledProcessError: Command '['ostree', '--repo=/tmp/lorax.valebh9x/iso-graft/content/repo', 'pull', '--mirror', 'ostree-mirror', 'fedora-atomic/24/x86_64/docker-host']' returned non-zero exit status 1
Finish: shell


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Colin Walters 2016-03-14 18:10:31 UTC
I don't like it much, but lorax puts subprocess output in `program.log`, so we'll need that to debug.

If one is implementing a CI/CD system, I'd export `program.log` as an artifact.

Comment 2 Dennis Gilmore 2016-03-14 22:39:11 UTC
The full log is at 
https://kojipkgs.fedoraproject.org/compose/branched/Fedora-24-20160314.n.0/logs/x86_64/atomic  it does look like it is getting a 404 error, but why I am not sure

Comment 3 Dennis Gilmore 2016-03-14 22:55:16 UTC
https://git.fedorahosted.org/cgit/fedora-atomic.git/tree/fedora-atomic-docker-host.json?h=f24

"ref": "fedora-atomic/rawhide/x86_64/docker-host",

    "repos": ["fedora-rawhide"],

    "selinux": true,

    "documentation": false,

    "automatic_version_prefix": "23",


the ref, repos and automatic_version_prefix are wrong. please fix.

Comment 4 Paul W. Frields 2016-03-15 20:12:23 UTC
Created attachment 1136748 [details]
patch locations for F24

Comment 5 Paul W. Frields 2016-03-15 20:25:36 UTC
Sorry, that's only half the fix. Dennis tells me the fedora.repo file also needs to exist in the tree, rather than fedora-rawhide.repo, with corrected content.

Dennis can let us know if any of this is wrong, but I lifted straight from the f23 branch:

https://demo.modernpaste.com/paste/Kr4YrsELQcbAIUl-cotn9RQDRB9BZ42MRHb4Tt8RGHY=/raw

Comment 6 Paul W. Frields 2016-03-15 21:08:25 UTC
Created attachment 1136763 [details]
Fixed - patch locations for F24

Comment 7 Colin Walters 2016-03-18 17:54:38 UTC
Sorry about the delay, the bugzilla mail here got lost in a deluge of other stuff.

Thanks a ton for patching this!  It almost worked, I just had to set gpgverify=0 due to:

https://github.com/projectatomic/rpm-ostree/issues/237

Committed as:

https://git.fedorahosted.org/cgit/fedora-atomic.git/commit/?h=f24

And sorry about not having tested the branching.  I filed
https://github.com/projectatomic/rpm-ostree/issues/236

which would also help, although my original intention with the JSON was that other higher level tools (e.g. pungi) would generate parts of the JSON.